mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2024-11-24 20:48:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
crosvm/cros_async/Cargo.toml

25 lines
503 B
TOML
Raw Normal View History

Add a cros_async crate. This crate will house code using the new async/await features to be used by other parts of crosvm. Start the crate with a Future executor that runs tasks in a single thread and allows futures that block on system file descriptors. Change-Id: If77778ac056210dabbfc6e6e1e63df1c1b904a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1955045 Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Dylan Reid <dgreid@chromium.org>
2019-11-23 00:41:01 +00:00
[package]
name = "cros_async"
version = "0.1.0"
authors = ["The Chromium OS Authors"]
edition = "2018"
[dependencies]
cros_async: add uring_executor Add an executor, similar to `fd_executor`, except driven by io_uring instead of `PollContext`. This will allow for queueing actions instead of waiting for 'ready' from poll. This reduces the number of syscalls and increases the parallelism possible when doing IO. Change-Id: Ie2e69cb09ee3ab1086ef31d5ebd0169843a8228d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2227083 Commit-Queue: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org>
2020-06-02 20:22:16 +00:00
io_uring = { path = "../io_uring" }
Add a cros_async crate. This crate will house code using the new async/await features to be used by other parts of crosvm. Start the crate with a Future executor that runs tasks in a single thread and allows futures that block on system file descriptors. Change-Id: If77778ac056210dabbfc6e6e1e63df1c1b904a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1955045 Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Dylan Reid <dgreid@chromium.org>
2019-11-23 00:41:01 +00:00
libc = "*"
paste = "*"
pin-utils = "0.1.0-alpha.4"
Add "base" crate and transition crosvm usages to it from sys_util For now, this crate simply re-exports all of sys_util, but it will be updated to provide new interfaces when needed. This is the first step to making crosvm not directly depend on sys_util, so that we can make the interface changes we need without fear of negatively affecting (i.e. completely breaking) other usages within chromeos. BUG=b:162363783 TEST=./build_test Change-Id: I7d0aa3d8a1f66af1c7fee8fd649723ef17027150 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2325168 Tested-by: Michael Hoyle <mikehoyle@google.com> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Michael Hoyle <mikehoyle@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Reviewed-by: Zach Reizner <zachr@chromium.org>
2020-08-03 03:09:41 +00:00
base = { path = "../base" }
Add a cros_async crate. This crate will house code using the new async/await features to be used by other parts of crosvm. Start the crate with a Future executor that runs tasks in a single thread and allows futures that block on system file descriptors. Change-Id: If77778ac056210dabbfc6e6e1e63df1c1b904a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1955045 Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Dylan Reid <dgreid@chromium.org>
2019-11-23 00:41:01 +00:00
syscall_defines = { path = "../syscall_defines" }
cros_async: Refactor executors This CL includes several smaller changes to how executors work: * Replace BTreeMap with Slab, which should give us some small performance benefits by giving O(1) lookups and reducing memory allocations when adding new I/O operations. It also gives some improvements to readability as we no longer have to carry around "next_*" variables. Slab has no dependencies and we're already pulling it in via the futures crate. * WakerToken no longer implements Clone. * Merge pending_ops and completed_ops in URingExecutor into a single `ops` Slab and introduce an OpStatus enum that indicates whether an operation is pending or completed. This also fixes a resource leak where an operation that was canceled before completion would end up staying in completed_ops ~forever. Add a test for this leak. * Add a generation number to RingWakerState and include it in all RegisteredSources. Since a RegisteredSource can outlive the RingWakerState that created it, the generation number ensures that it will only affect the RingWakerState that created it. Add a test for this. * Poison RegisteredSource so that it doesn't implement Send or Sync. Since it's associated with a thread-local executor, sending it across thread boundaries is not ok. BUG=none TEST=unit tests Change-Id: I43dcfbb8166002995ec8773522c22fab8fb2da9e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2374885 Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Commit-Queue: Chirantan Ekbote <chirantan@chromium.org>
2020-08-25 10:03:44 +00:00
slab = "0.4"
Add a cros_async crate. This crate will house code using the new async/await features to be used by other parts of crosvm. Start the crate with a Future executor that runs tasks in a single thread and allows futures that block on system file descriptors. Change-Id: If77778ac056210dabbfc6e6e1e63df1c1b904a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1955045 Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Dylan Reid <dgreid@chromium.org>
2019-11-23 00:41:01 +00:00
[dependencies.futures]
version = "*"
default-features = false
cros_async: Make raw waker Send + Sync std::task::Waker unconditionally implements Send + Sync so the raw waker that we provide also must implement those traits. Switch to using an Arc<AtomicBool>. This also fixes an inconsistency where the waker was defined to be an Rc<Cell<bool>> but all the vtable functions were treating as an Rc<AtomicBool>. To reduce the vtable boilerplate use the ArcWake trait from the futures crate. BUG=none TEST=unit tests Change-Id: I3870e4d7f6ce0de9f6ac3313a2f4474ae29018b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2287079 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Chirantan Ekbote <chirantan@chromium.org> Commit-Queue: Chirantan Ekbote <chirantan@chromium.org>
2020-07-08 10:24:04 +00:00
features = ["alloc"]
uring/async: Add fsync and fallocate These will be needed by by block. Note that support for uring fallocate was added in 5.6. The users will have to handle falling back to synchronous calls if fallocate returns EINVAL. BUG=901139 TEST=added fallocate unit tests Change-Id: I51d635adcf0bb4dd55c5bfe50719f2fde2b88e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2274996 Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Commit-Queue: Dylan Reid <dgreid@chromium.org>
2020-06-25 23:43:44 +00:00
[dev-dependencies]
cros_async: Fix reference to mem being dropped early The Rc to BackingMemory that is passed in to memory operations was being dropped before it is safe, The kernel can still access it until the op is completed, so keep the reference in the pending_ops map. Add tests so that this safety guarantees made by the executor are exercise in unit tests. Thanks to nkgold for finding the issue via code inspection. BUG=none TEST=cargo test dont_drop_backing_mem, cargo run with uring block and run fio tests. Change-Id: I8e4efedbbafefcbd57d7d7c340dc91a9b159b38c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2345377 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Dylan Reid <dgreid@chromium.org>
2020-08-06 23:25:25 +00:00
base = { path = "../base" }
uring/async: Add fsync and fallocate These will be needed by by block. Note that support for uring fallocate was added in 5.6. The users will have to handle falling back to synchronous calls if fallocate returns EINVAL. BUG=901139 TEST=added fallocate unit tests Change-Id: I51d635adcf0bb4dd55c5bfe50719f2fde2b88e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2274996 Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Commit-Queue: Dylan Reid <dgreid@chromium.org>
2020-06-25 23:43:44 +00:00
tempfile = { path = "../tempfile" }
vm_memory: Implement cros_async::BackingMemory for GuestMemory Implementing `BackingMemory` signals that `GuestMemory` regions can be used in uring transactions where the lifetime in which the kernel can modify the memory is not well defined. Change-Id: I3541fff4c5dac226062a94483672f570e7adeb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2275725 Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> Commit-Queue: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org>
2020-06-03 01:33:33 +00:00
vm_memory = { path = "../vm_memory" }
Reference in a new issue Copy permalink