mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2024-11-24 20:48:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
crosvm/metrics/Cargo.toml

23 lines
575 B
TOML
Raw Normal View History

Revert "Revert "metrics: Add metrics crate."" This reverts commit 55a5c8d8f9969be5510115b3876b2f0fefdbcb06. In order to accommodate the removal of the UnixSeqPacket+CloseNotifier change, I updated the controller.rs to reference platform-specific internal implementations. On Windows, CloseNotifier is used to detect closed Tubes. On Linux, we rely on PollContext returning because the socket fd is hung up. Some minor adjustmets to the code were made just to allow as litte duplication as possible. In the end, very little logic has changed from the original CL, it's just moved around. TL;DR: This fixes the downstream regression by removing its dependency on the breaking changes to base. BUG=b:232316549 FIXED=b:232316549 TEST=Crosvm tests Change-Id: I946d5096f7a312538c3c694950697fab1be7f0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3661257 Commit-Queue: Michael Hoyle <mikehoyle@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com>
2022-05-23 20:18:04 +00:00
[package]
name = "metrics"
version = "0.1.0"
Fix remaining Chrome/Chromium OS instances These should be written as ChromeOS and ChromiumOS (without the space) to match the updated branding. The copyright headers were already migrated to the new style (https://crrev.com/c/3894243), but there were some more instances left over. BUG=None TEST=tools/cargo-doc Change-Id: I8c76aea2eb33b2e370ab71ee9b5cc0a4cfd00585 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4129934 Reviewed-by: Dennis Kempin <denniskempin@google.com> Commit-Queue: Daniel Verkamp <dverkamp@chromium.org>
2022-12-29 21:24:33 +00:00
authors = ["The ChromiumOS Authors"]
Revert "Revert "metrics: Add metrics crate."" This reverts commit 55a5c8d8f9969be5510115b3876b2f0fefdbcb06. In order to accommodate the removal of the UnixSeqPacket+CloseNotifier change, I updated the controller.rs to reference platform-specific internal implementations. On Windows, CloseNotifier is used to detect closed Tubes. On Linux, we rely on PollContext returning because the socket fd is hung up. Some minor adjustmets to the code were made just to allow as litte duplication as possible. In the end, very little logic has changed from the original CL, it's just moved around. TL;DR: This fixes the downstream regression by removing its dependency on the breaking changes to base. BUG=b:232316549 FIXED=b:232316549 TEST=Crosvm tests Change-Id: I946d5096f7a312538c3c694950697fab1be7f0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3661257 Commit-Queue: Michael Hoyle <mikehoyle@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com>
2022-05-23 20:18:04 +00:00
edition = "2021"
metrics: add missing features in Cargo.toml There are cfg(feature = "...") checks testing "experimental" and "collect" features, but those aren't declared in Cargo.toml; cargo warns of this in newer versions, so declare them, even though they're never enabled in upstream crosvm. BUG=None TEST=cargo +nightly build Change-Id: I9893ec56f6f3362cc73b5e128c836b2a0f0e8e9e Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5672327 Reviewed-by: Noah Gold <nkgold@google.com> Commit-Queue: Daniel Verkamp <dverkamp@chromium.org>
2024-07-02 21:55:02 +00:00
[features]
collect = []
experimental = []
Revert "Revert "metrics: Add metrics crate."" This reverts commit 55a5c8d8f9969be5510115b3876b2f0fefdbcb06. In order to accommodate the removal of the UnixSeqPacket+CloseNotifier change, I updated the controller.rs to reference platform-specific internal implementations. On Windows, CloseNotifier is used to detect closed Tubes. On Linux, we rely on PollContext returning because the socket fd is hung up. Some minor adjustmets to the code were made just to allow as litte duplication as possible. In the end, very little logic has changed from the original CL, it's just moved around. TL;DR: This fixes the downstream regression by removing its dependency on the breaking changes to base. BUG=b:232316549 FIXED=b:232316549 TEST=Crosvm tests Change-Id: I946d5096f7a312538c3c694950697fab1be7f0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3661257 Commit-Queue: Michael Hoyle <mikehoyle@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com>
2022-05-23 20:18:04 +00:00
[dependencies]
Cargo.toml: avoid "*" versions for external crates Ensure that every Cargo.toml dependency on a third-party crates.io crate specifies at least a major version, or a minor version for 0.x crates, to ensure that if a new major version is published, it cannot cause API breaks. The versions are selected to match the ones already in Cargo.lock, so this should have no functional change, but it will help prevent new "*" versions from being introduced via copy-and-paste. For rationale, see the Cargo FAQ: <https://doc.rust-lang.org/cargo/faq.html#can-libraries-use--as-a-version-for-their-dependencies> `minijail`, `audio_streams`, and `cras` are left as "*" for now, since they have unusual situations (imported from a submodule and/or replaced at build time with ebuild magic). BUG=None TEST=tools/dev_container tools/presubmit TEST=verify Cargo.lock is unchanged Change-Id: Ifa18199f812f01d2d10bfb4146b3353c1a76527c Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5555656 Reviewed-by: Frederick Mayle <fmayle@google.com> Commit-Queue: Daniel Verkamp <dverkamp@chromium.org>
2024-05-21 22:37:42 +00:00
anyhow = "1"
Revert "Revert "metrics: Add metrics crate."" This reverts commit 55a5c8d8f9969be5510115b3876b2f0fefdbcb06. In order to accommodate the removal of the UnixSeqPacket+CloseNotifier change, I updated the controller.rs to reference platform-specific internal implementations. On Windows, CloseNotifier is used to detect closed Tubes. On Linux, we rely on PollContext returning because the socket fd is hung up. Some minor adjustmets to the code were made just to allow as litte duplication as possible. In the end, very little logic has changed from the original CL, it's just moved around. TL;DR: This fixes the downstream regression by removing its dependency on the breaking changes to base. BUG=b:232316549 FIXED=b:232316549 TEST=Crosvm tests Change-Id: I946d5096f7a312538c3c694950697fab1be7f0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3661257 Commit-Queue: Michael Hoyle <mikehoyle@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com>
2022-05-23 20:18:04 +00:00
base = { path = "../base" }
Cargo.toml: avoid "*" versions for external crates Ensure that every Cargo.toml dependency on a third-party crates.io crate specifies at least a major version, or a minor version for 0.x crates, to ensure that if a new major version is published, it cannot cause API breaks. The versions are selected to match the ones already in Cargo.lock, so this should have no functional change, but it will help prevent new "*" versions from being introduced via copy-and-paste. For rationale, see the Cargo FAQ: <https://doc.rust-lang.org/cargo/faq.html#can-libraries-use--as-a-version-for-their-dependencies> `minijail`, `audio_streams`, and `cras` are left as "*" for now, since they have unusual situations (imported from a submodule and/or replaced at build time with ebuild magic). BUG=None TEST=tools/dev_container tools/presubmit TEST=verify Cargo.lock is unchanged Change-Id: Ifa18199f812f01d2d10bfb4146b3353c1a76527c Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5555656 Reviewed-by: Frederick Mayle <fmayle@google.com> Commit-Queue: Daniel Verkamp <dverkamp@chromium.org>
2024-05-21 22:37:42 +00:00
cfg-if = "1"
metrics: upstream local metrics related changes These metrics allows to measure io related performance. BUG=b:286107739 TEST=none Change-Id: Ieb0920a239e0e5d952ef51210393350ca34ee611 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4601851 Reviewed-by: Noah Gold <nkgold@google.com> Commit-Queue: Vikram Auradkar <auradkar@google.com>
2023-06-08 17:18:43 +00:00
serde = { version = "1", features = ["derive"] }
sync = { path = "../common/sync" }
metrics: Remove downstream metrics dependencies Add a metrics_event package instead of relying on metric events provided out of a vendor/ crate. The new API defines the same events as the existing vendor API, except it removes any dependencies on downstream details. To allow downstream projects to define their own events, the new API adds a vendor metrics_event package to support downstream-only event types. BUG=b:332466813 TEST=./tools/dev_container ./tools/presubmit all Change-Id: I766ad6ca2a0a437bb487e27fb84a4984f66c9770 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5400361 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Reviewed-by: Noah Gold <nkgold@google.com> Reviewed-by: Dennis Kempin <denniskempin@google.com> Commit-Queue: David Stevens <stevensd@chromium.org>
2024-03-27 06:36:42 +00:00
metrics_events = { path = "../metrics_events" }
metrics: move noop metrics under generic downstreams will override metrics_product crate BUG=b:286107739 TEST=none Change-Id: I90e05289d509c3f3ff85cc3441c89aad3507f0b0 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5356287 Commit-Queue: Vikram Auradkar <auradkar@google.com> Reviewed-by: Noah Gold <nkgold@google.com>
2024-03-08 02:00:01 +00:00
metrics_product = { path = "../vendor/generic/metrics", package = "metrics_generic" }
Revert "Revert "metrics: Add metrics crate."" This reverts commit 55a5c8d8f9969be5510115b3876b2f0fefdbcb06. In order to accommodate the removal of the UnixSeqPacket+CloseNotifier change, I updated the controller.rs to reference platform-specific internal implementations. On Windows, CloseNotifier is used to detect closed Tubes. On Linux, we rely on PollContext returning because the socket fd is hung up. Some minor adjustmets to the code were made just to allow as litte duplication as possible. In the end, very little logic has changed from the original CL, it's just moved around. TL;DR: This fixes the downstream regression by removing its dependency on the breaking changes to base. BUG=b:232316549 FIXED=b:232316549 TEST=Crosvm tests Change-Id: I946d5096f7a312538c3c694950697fab1be7f0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3661257 Commit-Queue: Michael Hoyle <mikehoyle@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com>
2022-05-23 20:18:04 +00:00
[target.'cfg(windows)'.dependencies]
Use UTC rather than local timezone for Windows metrics. BUG=b:326256145 Change-Id: Ifabb377a258c8bb8d492ace505341f8f419af9cb Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5340449 Reviewed-by: Vikram Auradkar <auradkar@google.com> Commit-Queue: Andrew Walbran <qwandor@google.com> Auto-Submit: Andrew Walbran <qwandor@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
2024-03-04 13:56:24 +00:00
chrono = { version = "0.4.34", default-features = false, features = ["now"] }
Cargo.toml: avoid "*" versions for external crates Ensure that every Cargo.toml dependency on a third-party crates.io crate specifies at least a major version, or a minor version for 0.x crates, to ensure that if a new major version is published, it cannot cause API breaks. The versions are selected to match the ones already in Cargo.lock, so this should have no functional change, but it will help prevent new "*" versions from being introduced via copy-and-paste. For rationale, see the Cargo FAQ: <https://doc.rust-lang.org/cargo/faq.html#can-libraries-use--as-a-version-for-their-dependencies> `minijail`, `audio_streams`, and `cras` are left as "*" for now, since they have unusual situations (imported from a submodule and/or replaced at build time with ebuild magic). BUG=None TEST=tools/dev_container tools/presubmit TEST=verify Cargo.lock is unchanged Change-Id: Ifa18199f812f01d2d10bfb4146b3353c1a76527c Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5555656 Reviewed-by: Frederick Mayle <fmayle@google.com> Commit-Queue: Daniel Verkamp <dverkamp@chromium.org>
2024-05-21 22:37:42 +00:00
winapi = { version = "0.3" }
Reference in a new issue Copy permalink