mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2024-11-24 20:48:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
crosvm/cros_async/Cargo.toml

29 lines
627 B
TOML
Raw Normal View History

Add a cros_async crate. This crate will house code using the new async/await features to be used by other parts of crosvm. Start the crate with a Future executor that runs tasks in a single thread and allows futures that block on system file descriptors. Change-Id: If77778ac056210dabbfc6e6e1e63df1c1b904a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1955045 Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Dylan Reid <dgreid@chromium.org>
2019-11-23 00:41:01 +00:00
[package]
name = "cros_async"
version = "0.1.0"
authors = ["The Chromium OS Authors"]
edition = "2018"
[dependencies]
Replace PollOrRing w/ async trait IoSourceExt. This CL makes the following fundamental changes to cros_async: 1. Removes PollOrRing and replaces it with IoSourceExt, and the subtraits ReadAsync & WriteAsync. The blanket implementation of IoSourceExt has been dropped, and replaced with source specific implementations of the trait. Those implementations are where the code from PollOrRing has been moved. 2. Pinning for IoSource has been dropped from UringSource & the uring futures. This appears to be safe because the IoSource doesn't contain any self refs, or perform any operations beyond forwarding to the RegisteredSource. (The FD is duped before being passed to RingWakerState by RegisteredSource, so there doesn't seem to be any data which would require pinning.) 3. U64Source was replaced by EventAsync. It also switches all Error enums to use thiserror, which reduces boilerplate. BUG=None TEST=cargo test -p cros_async Cq-Depend: chromium:2421742 Change-Id: Ie1dd958da2e1f8dec1ae1fd8c0b4e754223d330d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2416996 Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Noah Gold <nkgold@google.com>
2020-09-17 01:21:58 +00:00
async-trait = "0.1.36"
cros_async: Refactor executors There are a lot of changes in this one but these are the high-level points: * Both executors now support non-fd futures and it's now possible to start a poll operation on one thread and then await the result inside a UringExecutor on another thread. The reverse doesn't work yet but will once we make UringContext sync. * A few layers of indirection have been removed so hopefully both the implementation and the interface are simpler. * The thread local magic is gone in favor of directly calling methods on an executor. Executor handles can be cheaply cloned to make this easier. * Heap allocations are limited to the spawn and spawn_local methods so it's possible to completely avoid heap allocations if callers only use the run_until method. * The IoSource, Executor, FutureList traits are gone. BUG=none TEST=unit tests Cq-Depend: chromium:2629068 Change-Id: I86053007929c36da66f3b2499cdefce0b5e9a180 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2571401 Commit-Queue: Chirantan Ekbote <chirantan@chromium.org> Tested-by: Chirantan Ekbote <chirantan@chromium.org> Reviewed-by: Noah Gold <nkgold@google.com> Reviewed-by: Dylan Reid <dgreid@chromium.org>
2020-12-03 15:20:39 +00:00
async-task = "4"
cros_async: add uring_executor Add an executor, similar to `fd_executor`, except driven by io_uring instead of `PollContext`. This will allow for queueing actions instead of waiting for 'ready' from poll. This reduces the number of syscalls and increases the parallelism possible when doing IO. Change-Id: Ie2e69cb09ee3ab1086ef31d5ebd0169843a8228d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2227083 Commit-Queue: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org>
2020-06-02 20:22:16 +00:00
io_uring = { path = "../io_uring" }
Add a cros_async crate. This crate will house code using the new async/await features to be used by other parts of crosvm. Start the crate with a Future executor that runs tasks in a single thread and allows futures that block on system file descriptors. Change-Id: If77778ac056210dabbfc6e6e1e63df1c1b904a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1955045 Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Dylan Reid <dgreid@chromium.org>
2019-11-23 00:41:01 +00:00
libc = "*"
Cargo.lock: Uprev cfg-if and paste crates Use the latest version of cfg-if and paste, which gdbstub crate will require. BUG=chromium:1141812 TEST=cargo build Cq-Depend: chromium:2507270 Change-Id: I9187cfc9a880f62b2aa1fcf5e5d47a720e5fbe60 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2499241 Tested-by: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Reviewed-by: Zach Reizner <zachr@chromium.org> Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
2020-10-26 07:58:55 +00:00
paste = "1.0"
Add a cros_async crate. This crate will house code using the new async/await features to be used by other parts of crosvm. Start the crate with a Future executor that runs tasks in a single thread and allows futures that block on system file descriptors. Change-Id: If77778ac056210dabbfc6e6e1e63df1c1b904a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1955045 Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Dylan Reid <dgreid@chromium.org>
2019-11-23 00:41:01 +00:00
pin-utils = "0.1.0-alpha.4"
cros_async: Refactor executors There are a lot of changes in this one but these are the high-level points: * Both executors now support non-fd futures and it's now possible to start a poll operation on one thread and then await the result inside a UringExecutor on another thread. The reverse doesn't work yet but will once we make UringContext sync. * A few layers of indirection have been removed so hopefully both the implementation and the interface are simpler. * The thread local magic is gone in favor of directly calling methods on an executor. Executor handles can be cheaply cloned to make this easier. * Heap allocations are limited to the spawn and spawn_local methods so it's possible to completely avoid heap allocations if callers only use the run_until method. * The IoSource, Executor, FutureList traits are gone. BUG=none TEST=unit tests Cq-Depend: chromium:2629068 Change-Id: I86053007929c36da66f3b2499cdefce0b5e9a180 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2571401 Commit-Queue: Chirantan Ekbote <chirantan@chromium.org> Tested-by: Chirantan Ekbote <chirantan@chromium.org> Reviewed-by: Noah Gold <nkgold@google.com> Reviewed-by: Dylan Reid <dgreid@chromium.org>
2020-12-03 15:20:39 +00:00
slab = "0.4"
sync = { path = "../sync" }
Refactor cros_async interface to avoid RawFd. Instead of creating IoSourceExt from AsRawFd implementers, we've switched to creating from a marker trait `IntoAsync`. This lets us use other types like RawDescriptor easily with this crate. By using the marker, we also provide some type safety by requiring consumers of IoSourceExt to declare that their type is expected to work with async operations. This way we can provide stronger guarantees that an async IO trait object will behave in a reasonable way. This CL also purges the cros_async -> base and io_uring -> base references, and provides the base types needed to add new async primitives to base. BUG=none TEST=builds Change-Id: I0b0ce6ca7938b22ae8e8fb4e604439f0292678f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2504481 Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Noah Gold <nkgold@google.com> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
2020-11-06 03:10:36 +00:00
sys_util = { path = "../sys_util" }
Add a cros_async crate. This crate will house code using the new async/await features to be used by other parts of crosvm. Start the crate with a Future executor that runs tasks in a single thread and allows futures that block on system file descriptors. Change-Id: If77778ac056210dabbfc6e6e1e63df1c1b904a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1955045 Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Dylan Reid <dgreid@chromium.org>
2019-11-23 00:41:01 +00:00
syscall_defines = { path = "../syscall_defines" }
Replace PollOrRing w/ async trait IoSourceExt. This CL makes the following fundamental changes to cros_async: 1. Removes PollOrRing and replaces it with IoSourceExt, and the subtraits ReadAsync & WriteAsync. The blanket implementation of IoSourceExt has been dropped, and replaced with source specific implementations of the trait. Those implementations are where the code from PollOrRing has been moved. 2. Pinning for IoSource has been dropped from UringSource & the uring futures. This appears to be safe because the IoSource doesn't contain any self refs, or perform any operations beyond forwarding to the RegisteredSource. (The FD is duped before being passed to RingWakerState by RegisteredSource, so there doesn't seem to be any data which would require pinning.) 3. U64Source was replaced by EventAsync. It also switches all Error enums to use thiserror, which reduces boilerplate. BUG=None TEST=cargo test -p cros_async Cq-Depend: chromium:2421742 Change-Id: Ie1dd958da2e1f8dec1ae1fd8c0b4e754223d330d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2416996 Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Noah Gold <nkgold@google.com>
2020-09-17 01:21:58 +00:00
thiserror = "1.0.20"
Add a cros_async crate. This crate will house code using the new async/await features to be used by other parts of crosvm. Start the crate with a Future executor that runs tasks in a single thread and allows futures that block on system file descriptors. Change-Id: If77778ac056210dabbfc6e6e1e63df1c1b904a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1955045 Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Dylan Reid <dgreid@chromium.org>
2019-11-23 00:41:01 +00:00
[dependencies.futures]
version = "*"
default-features = false
cros_async: Make raw waker Send + Sync std::task::Waker unconditionally implements Send + Sync so the raw waker that we provide also must implement those traits. Switch to using an Arc<AtomicBool>. This also fixes an inconsistency where the waker was defined to be an Rc<Cell<bool>> but all the vtable functions were treating as an Rc<AtomicBool>. To reduce the vtable boilerplate use the ArcWake trait from the futures crate. BUG=none TEST=unit tests Change-Id: I3870e4d7f6ce0de9f6ac3313a2f4474ae29018b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2287079 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Chirantan Ekbote <chirantan@chromium.org> Commit-Queue: Chirantan Ekbote <chirantan@chromium.org>
2020-07-08 10:24:04 +00:00
features = ["alloc"]
uring/async: Add fsync and fallocate These will be needed by by block. Note that support for uring fallocate was added in 5.6. The users will have to handle falling back to synchronous calls if fallocate returns EINVAL. BUG=901139 TEST=added fallocate unit tests Change-Id: I51d635adcf0bb4dd55c5bfe50719f2fde2b88e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2274996 Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Commit-Queue: Dylan Reid <dgreid@chromium.org>
2020-06-25 23:43:44 +00:00
[dev-dependencies]
cros_async: Refactor executors There are a lot of changes in this one but these are the high-level points: * Both executors now support non-fd futures and it's now possible to start a poll operation on one thread and then await the result inside a UringExecutor on another thread. The reverse doesn't work yet but will once we make UringContext sync. * A few layers of indirection have been removed so hopefully both the implementation and the interface are simpler. * The thread local magic is gone in favor of directly calling methods on an executor. Executor handles can be cheaply cloned to make this easier. * Heap allocations are limited to the spawn and spawn_local methods so it's possible to completely avoid heap allocations if callers only use the run_until method. * The IoSource, Executor, FutureList traits are gone. BUG=none TEST=unit tests Cq-Depend: chromium:2629068 Change-Id: I86053007929c36da66f3b2499cdefce0b5e9a180 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2571401 Commit-Queue: Chirantan Ekbote <chirantan@chromium.org> Tested-by: Chirantan Ekbote <chirantan@chromium.org> Reviewed-by: Noah Gold <nkgold@google.com> Reviewed-by: Dylan Reid <dgreid@chromium.org>
2020-12-03 15:20:39 +00:00
futures = { version = "*", features = ["executor"] }
uring/async: Add fsync and fallocate These will be needed by by block. Note that support for uring fallocate was added in 5.6. The users will have to handle falling back to synchronous calls if fallocate returns EINVAL. BUG=901139 TEST=added fallocate unit tests Change-Id: I51d635adcf0bb4dd55c5bfe50719f2fde2b88e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2274996 Reviewed-by: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org> Commit-Queue: Dylan Reid <dgreid@chromium.org>
2020-06-25 23:43:44 +00:00
tempfile = { path = "../tempfile" }
vm_memory: Implement cros_async::BackingMemory for GuestMemory Implementing `BackingMemory` signals that `GuestMemory` regions can be used in uring transactions where the lifetime in which the kernel can modify the memory is not well defined. Change-Id: I3541fff4c5dac226062a94483672f570e7adeb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2275725 Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> Commit-Queue: Dylan Reid <dgreid@chromium.org> Tested-by: Dylan Reid <dgreid@chromium.org>
2020-06-03 01:33:33 +00:00
vm_memory = { path = "../vm_memory" }
Reference in a new issue Copy permalink