mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2024-11-28 09:33:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

clippy: Fix cros_async

Browse source 
This is the last one. Just a few nits and we can now run clippy on all
crates.

BUG=b:192373803
TEST=./tools/presubmit

Change-Id: I93ad9ce3b1cf0718bda8588279d7e1a891a0a6f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3439052
Reviewed-by: Noah Gold <nkgold@google.com>
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Commit-Queue: Dennis Kempin <denniskempin@google.com>
This commit is contained in:
Dennis Kempin 2022-02-07 11:29:09 -08:00 committed by Commit Bot
parent 04ccba5143
commit 5eb7743abd
2 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
common/cros_async/src/uring_source.rs
View file

@ -237,7 +237,7 @@ mod tests {
// Use guest memory as a test file, it implements AsRawFd. // Use guest memory as a test file, it implements AsRawFd.
let mut source = tempfile().unwrap(); let mut source = tempfile().unwrap();
let data = vec![0x55; 8192]; let data = vec![0x55; 8192];
source.write(&data).unwrap(); source.write_all(&data).unwrap();
let io_obj = UringSource::new(source, &ex).unwrap(); let io_obj = UringSource::new(source, &ex).unwrap();
@ -390,7 +390,7 @@ mod tests {
Either::Right((5, pending)) => { Either::Right((5, pending)) => {
// Write to the pipe so that the kernel will release the memory associated with // Write to the pipe so that the kernel will release the memory associated with
// the uring read operation. // the uring read operation.
w.write(&[0]).expect("failed to write to pipe"); w.write_all(&[0]).expect("failed to write to pipe");
::std::mem::drop(pending); ::std::mem::drop(pending);
} }
_ => panic!("unexpected select result"), _ => panic!("unexpected select result"),

7
tools/clippy
View file

@ -12,10 +12,6 @@
set -e set -e
cd "$(dirname $0)/.." cd "$(dirname $0)/.."
EXCLUDE_COMMON=(
common/cros_async # 8 errors
)
# Note: Clippy checks are configured in .cargo/config.toml # Note: Clippy checks are configured in .cargo/config.toml
echo "Clippy crosvm workspace" echo "Clippy crosvm workspace"
cargo clippy \ cargo clippy \
@ -25,8 +21,7 @@ cargo clippy \
"$@" -- -Dwarnings "$@" -- -Dwarnings
for crate in common/*; do for crate in common/*; do
if [ -d "${crate}" ] && if [ -d "${crate}" ]; then
[[ ! " ${EXCLUDE_COMMON[*]} " =~ " ${crate} " ]]; then
echo "" echo ""
echo "Clippy ${crate}" echo "Clippy ${crate}"
(cd "${crate}" && (cd "${crate}" &&