From 9227b78c4f3353697d741e3d7dc523a149dbeb3f Mon Sep 17 00:00:00 2001 From: "A. Cody Schuffelen" Date: Fri, 14 Jun 2024 12:38:26 -0700 Subject: [PATCH] Remove error message for not implementing set_backend_req_connection This error message is displayed on using the vhost-user block implementation. ``` ERROR devices::virtio::vhost::user::device::handler] set_backend_req_connection is not implemented ``` fmayle@ and dverkamp@ pointed out in code review that this doesn't signify an actual error, as crosvm also handles this message at a different layer. Bug: b:347308400 Test: Run with cuttlefish Change-Id: I59f5fcefbc60aab4b2b1d7c188740eb6289bee41 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5634186 Commit-Queue: Cody Schuffelen Reviewed-by: Daniel Verkamp Reviewed-by: Frederick Mayle --- devices/src/virtio/vhost/user/device/handler.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/devices/src/virtio/vhost/user/device/handler.rs b/devices/src/virtio/vhost/user/device/handler.rs index daa39a0c3d..c6ee6874c9 100644 --- a/devices/src/virtio/vhost/user/device/handler.rs +++ b/devices/src/virtio/vhost/user/device/handler.rs @@ -185,9 +185,7 @@ pub trait VhostUserDevice { /// /// This method will be called when `VhostUserProtocolFeatures::BACKEND_REQ` is /// negotiated. - fn set_backend_req_connection(&mut self, _conn: Arc) { - error!("set_backend_req_connection is not implemented"); - } + fn set_backend_req_connection(&mut self, _conn: Arc) {} /// Used to stop non queue workers that `VhostUserDevice::stop_queue` can't stop. May or may /// not also stop all queue workers.