mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2024-11-25 05:03:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

devices: virtio: gpu: delete cursor queue fence completion deadcode

Browse source 
I think this has been deadcode since 2019 (https://crrev.com/c/1775365).
It isn't obvious to me whether requests on the cursor queue are allowed
to specify VIRTIO_GPU_FLAG_FENCE. If they are, then this is a bug: the
cursor requests that use a fence will never be completed.

Change-Id: Idb46b157a534a2a0d12cc97348df3566a27fb9d9
Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4775762
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Reviewed-by: Idan Raiter <idanr@google.com>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
This commit is contained in:
Frederick Mayle 2023-08-11 12:40:07 -07:00 committed by crosvm LUCI
parent d13a8cf231
commit d3d6d2960b
1 changed files with 0 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
devices/src/virtio/gpu/mod.rs
View file

@ -9,7 +9,6 @@ mod virtio_gpu;
use std::cell::RefCell;
use std::collections::BTreeMap;
use std::collections::VecDeque;
use std::io::Read;
use std::path::PathBuf;
use std::rc::Rc;
@ -325,7 +324,6 @@ pub struct ReturnDescriptor {
pub struct Frontend {
fence_state: Arc<Mutex<FenceState>>,
return_cursor_descriptors: VecDeque<ReturnDescriptor>,
virtio_gpu: VirtioGpu,
}
@ -333,7 +331,6 @@ impl Frontend {
fn new(virtio_gpu: VirtioGpu, fence_state: Arc<Mutex<FenceState>>) -> Frontend {
Frontend {
fence_state,
return_cursor_descriptors: Default::default(),
virtio_gpu,
}
}
@ -750,10 +747,6 @@ impl Frontend {
Some(ReturnDescriptor { desc_chain, len })
}
pub fn return_cursor(&mut self) -> Option<ReturnDescriptor> {
self.return_cursor_descriptors.pop_front()
}
pub fn event_poll(&self) {
self.virtio_gpu.event_poll();
}
@ -967,12 +960,6 @@ impl Worker {
}
}
// All cursor commands go first because they have higher priority.
while let Some(desc) = self.state.return_cursor() {
self.cursor_queue.add_used(desc.desc_chain, desc.len);
signal_used_cursor = true;
}
if display_available {
match self.state.process_display() {
ProcessDisplayResult::CloseRequested => {