From f2d11d94d760f75c8e737dad2809eb8729a02f07 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Tue, 24 Sep 2024 14:17:19 -0700 Subject: [PATCH] hypervisor: disable getsec and invvpid tests on Linux These tests currently don't pass on KVM (at least on AMD), and I don't think the tests are actually testing for the expected result (there is no configured IDT, so the system triple faults and ends up at the reset vector), which seems nontrivial to fix, so skip them on Linux for now. This makes `tools/dev_container tools/presubmit` pass for me again. Change-Id: Ifc31fdd88b270c1c37f0f105dc655be4048ed279 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5888352 Reviewed-by: Oystein Eftevaag Commit-Queue: Daniel Verkamp Reviewed-by: Frederick Mayle --- hypervisor/tests/hypervisor_virtualization.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hypervisor/tests/hypervisor_virtualization.rs b/hypervisor/tests/hypervisor_virtualization.rs index db5fd1f091..b1cfd3466a 100644 --- a/hypervisor/tests/hypervisor_virtualization.rs +++ b/hypervisor/tests/hypervisor_virtualization.rs @@ -1381,6 +1381,7 @@ global_asm_data!( "hlt", ); +#[cfg(not(unix))] #[test] fn test_getsec_instruction() { let setup = TestSetup { @@ -1605,6 +1606,7 @@ global_asm_data!( // TODO(b/342183625): invvpid instruction is not valid in real mode. Reconsider how we should write // this test. +#[cfg(not(unix))] #[test] fn test_invvpid_instruction() { let setup = TestSetup {