VSCode prompted me Better TOML extension is deprecated and Even
Better TOML should be used instead.
TESTED=toml support still works after rebuilding dev container
Change-Id: Ic7a71f99a89a47e139627fcd75e35acbdf3bef41
Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4728142
Auto-Submit: Zihan Chen <zihanchen@google.com>
Reviewed-by: Dennis Kempin <denniskempin@google.com>
Commit-Queue: Dennis Kempin <denniskempin@google.com>
Since we default to podman, we can get rid of the _user container and
run as root inside the container, which greatly simplifies the tooling.
This also allows us to provide a single, default devcontainer.json
for local development as well as codespaces.
podman can be used with this devcontainer.json as well, e.g. in
VSCode by setting:
"dev.containers.dockerPath": "podman"
The with_kvm/devcontainer.json can be used to add access to kvm, which
may not be available on all machines. So it's an optional config.
BUG=b:273529620
TEST=Open with devcontainer in VSCode with both docker and podman,
run `presubmit --no-delta`
TEST=tools/dev_container tools/presubmit --no-delta
Change-Id: I10e04898a0e1adb6e4939f6f2e0259dc9b9aa62d
Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4419666
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Reviewed-by: Zihan Chen <zihanchen@google.com>
Commit-Queue: Dennis Kempin <denniskempin@google.com>