The email will automatically pick a reviewer. This should be the
first choice for reviewer selection unless a subject matter OWNER
is available.
Change-Id: I0b21ea77b9b32436b65f917369ef5d5fe30e8653
Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5378900
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@google.com>
fmayle@ has been writing and reviewing CLs consistently in crosvm for
over a year. In addition to making major improvements in cros_async,
Frederick has been writing & reviewing major CrosVM wide changes for
the snapshotting project. He has a holistic view of CrosVM, and
thoughtfully reviews changes to minimize technical debt and optimize for
the long term health of the codebase. I believe the requirements for
global crosvm OWNERS have been well satisfied, and as such nominate
fmayle@ for inclusion in the role.
BUG=none
TEST=fmayle@ has been reviewing code in CrosVM for some time and has
demonstrated sound judgement.
Change-Id: I23344a359fdcf0acb6b8c4cb68aaa1ab1b6db325
Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4976012
Commit-Queue: Noah Gold <nkgold@google.com>
Reviewed-by: Keiichi Watanabe <keiichiw@chromium.org>
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Changes to Cargo.lock will require additional reviews by the
crosvm council to judge if added third party crates are can and
should be used.
BUG=b:239254933
TEST=gerrit validates OWNERS files
Change-Id: Ie3c275079ce737aeeb6ddcbcfed9f1514df34584
Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4068829
Commit-Queue: Dennis Kempin <denniskempin@google.com>
Reviewed-by: Steven Moreland <smoreland@google.com>
Reviewed-by: Christian Blichmann <cblichmann@google.com>
Reviewed-by: Frederick Mayle <fmayle@google.com>
Reviewed-by: Vikram Auradkar <auradkar@google.com>
This builder re-creates ci/build_merge_into_chromeos and just calls
the merge_bot script.
Eventually this could be better integrated with Luci UI. For now,
this is feature parity with Kokoro.
BUG=b:233913643
TEST=recipe.py run merge_into_chromeos
Change-Id: Ia5de775cad943687be654c3a054f1150ba9adbb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3673786
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
This should allow the bot to submit dry-runs to the CQ.
BUG=chromium:1290646
TEST=None
Change-Id: I44fc74c94129e7d136a161c1ba11445d7bf675c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3421730
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
denniskempin will inherit fuzzing or find someone to.
Change-Id: Icb4dc76949726c0d958dab41228ba848ec292c94
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2988148
Auto-Submit: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Dennis Kempin <denniskempin@google.com>
Commit-Queue: Dennis Kempin <denniskempin@google.com>
Tested-by: Dennis Kempin <denniskempin@google.com>
Adding a few people who frequently +2 changes across different teams
and timezones.
People on this list will also be able to set V+1, which is otherwise
going to be managed by Kokoro.
BUG=b:183147853
TEST=None
Change-Id: I11f20e58eaeeab9f219dc603e27ffdfe1dcbf2cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2773703
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Commit-Queue: Dennis Kempin <denniskempin@google.com>
When everybody's an OWNER, nobody is! Since crosvm doesn't have sticky +2,
we want anyone with committer access to self +2 when needed.
BUG=none
TEST=none
Change-Id: I18b71be6eff3612dba9ed98659815c7fc7f49160
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1901624
Tested-by: Stephen Barber <smbarber@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Tested-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
