No description
Find a file
Daniel Verkamp 186eb8b0db sys_util: wait on specific pid in panic_safe test
The fork::tests::panic_safe unit test has been hanging intermittently in
CQ runs.  The root cause isn't understood yet, but the most likely
explanation seems to be that the wait_process helper is hanging.
There should be only two causes for that hang: either the cloned process
is not exiting, or the wait() call in wait_process is not returning.
The wait() should only hang if another thread has already reaped the
cloned process.

In order to help debug the issue, change the general wait() to a
waitpid() on the specific cloned process ID.  This will give us more
information about what happens when the test fails - if the waitpid()
returns ECHILD instead of hanging, this will indicate that something
else is waiting on our child process and racing with our wait().

BUG=chromium:925725
TEST=cargo test --release -p sys_util panic_safe

Change-Id: Ib25d88b35b16c75d4d8fe62fc779c9470303368a
Signed-off-by: Daniel Verkamp <dverkamp@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1444317
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Zach Reizner <zachr@chromium.org>
2019-01-30 01:26:15 -08:00
aarch64 crosvm: x86_64 guest support for android device-tree 2019-01-28 14:17:10 -08:00
arch crosvm: x86_64 guest support for android device-tree 2019-01-28 14:17:10 -08:00
assertions crosvm: Split sub-crates into independent workspace 2019-01-03 15:04:23 -08:00
bit_field bitfield: Documentation and simplifications 2019-01-03 15:04:22 -08:00
crosvm_plugin plugin: allow retrieving and setting VM clock 2019-01-22 21:05:18 -08:00
data_model build: Restore ability to compile data_model and sys_util in isolation 2019-01-18 00:46:02 -08:00
devices devices: gpu: name gpu thread 2019-01-30 01:25:56 -08:00
enumn macros: Derive macro to generate integer to enum conversion 2018-12-07 17:35:43 -08:00
fuzz Add kernel_loader fuzzing 2018-01-12 22:37:48 -08:00
gpu_buffer crosvm: use updated minigbm APIs. 2019-01-14 03:31:38 -08:00
gpu_display crosvm: Support cros-rust version crosvm ebuild 2019-01-22 16:53:13 -08:00
gpu_renderer toolchain: Update to Rust 1.31.0 2018-12-13 19:28:04 -08:00
io_jail lint: Resolve the easier clippy lints 2018-12-03 20:32:03 -08:00
kernel_cmdline cargo fmt all source code 2018-10-09 21:14:05 -07:00
kernel_loader crosvm: x86_64 guest support for android device-tree 2019-01-28 14:17:10 -08:00
kokoro kokoro: Move the crosvm workdir 2019-01-26 00:59:57 -08:00
kvm kvm: take a reference to GuestMemory in Vcpu 2019-01-30 01:25:56 -08:00
kvm_sys lint: Resolve the easier clippy lints 2018-12-03 20:32:03 -08:00
msg_socket toolchain: Update to Rust 1.31.0 2018-12-13 19:28:04 -08:00
net_sys lint: Resolve the easier clippy lints 2018-12-03 20:32:03 -08:00
net_util net_util: Get tap interface name when using a raw fd 2019-01-07 19:40:14 -08:00
p9 toolchain: Update to Rust 1.31.0 2018-12-13 19:28:04 -08:00
plugin_proto plugin: allow retrieving and setting VM clock 2019-01-22 21:05:18 -08:00
qcow qcow: add no-op set_len() for QcowFile 2019-01-05 20:08:26 -08:00
qcow_utils toolchain: Update to Rust 1.31.0 2018-12-13 19:28:04 -08:00
rand_ish remove rand crate 2019-01-17 20:20:50 -08:00
resources resources: re-alphabetize imports 2019-01-13 13:52:15 -08:00
seccomp devices: gpu: name gpu thread 2019-01-30 01:25:56 -08:00
src crosvm: x86_64 guest support for android device-tree 2019-01-28 14:17:10 -08:00
sync sync: add Convar wrapper that panics instead of returning Result 2019-01-23 20:40:38 -08:00
sys_util sys_util: wait on specific pid in panic_safe test 2019-01-30 01:26:15 -08:00
syscall_defines crosvm: Split sub-crates into independent workspace 2019-01-03 15:04:23 -08:00
tempdir crosvm: Support cros-rust version crosvm ebuild 2019-01-22 16:53:13 -08:00
tests plugin: allow retrieving and setting VM clock 2019-01-22 21:05:18 -08:00
tpm2 tpm: Virtio tpm device 2019-01-24 07:43:30 -08:00
tpm2-sys tpm: Virtio tpm device 2019-01-24 07:43:30 -08:00
usb_util usb_util: add sandboxed-libusb feature 2018-12-20 13:49:37 -08:00
vhost sys_util: Combine GuestMemory::with_regions and with_regions_mut 2018-12-18 00:42:52 -08:00
virtio_sys cargo fmt all source code 2018-10-09 21:14:05 -07:00
vm_control crosvm: add suspend/resume commands 2019-01-23 20:40:38 -08:00
x86_64 crosvm: x86_64 guest support for android device-tree 2019-01-28 14:17:10 -08:00
.gitignore gitignore: Remove Cargo.lock 2017-06-17 01:12:44 -07:00
.gitmodules tpm: Add tpm2-sys crate 2019-01-13 03:23:13 -08:00
.rustfmt.toml Add basic rustfmt config 2018-09-15 20:58:19 -07:00
build_test add build_test script to automate crosvm test running 2017-09-01 12:39:19 -07:00
build_test.py crosvm: set ARM_TRIPLE to armv7a-cros-linux-gnueabihf 2018-09-26 10:33:18 -07:00
Cargo.lock crosvm: x86_64 guest support for android device-tree 2019-01-28 14:17:10 -08:00
Cargo.toml linux: Add ac97 device with CRAS backend 2019-01-27 10:43:26 -08:00
LICENSE add LICENSE and README 2017-04-17 14:06:21 -07:00
README.md readme: default mode is multiprocess 2019-01-24 00:51:35 -08:00
rust-toolchain toolchain: Update to Rust 1.31.0 2018-12-13 19:28:04 -08:00

crosvm - The Chrome OS Virtual Machine Monitor

This component, known as crosvm, runs untrusted operating systems along with virtualized devices. No actual hardware is emulated. This only runs VMs through the Linux's KVM interface. What makes crosvm unique is a focus on safety within the programming language and a sandbox around the virtual devices to protect the kernel from attack in case of an exploit in the devices.

Usage

To see the usage information for your version of crosvm, run crosvm or crosvm run --help.

Boot a Kernel

To run a very basic VM with just a kernel and default devices:

$ crosvm run "${KERNEL_PATH}"

The uncompressed kernel image, also known as vmlinux, can be found in your kernel build directory in the case of x86 at arch/x86/boot/compressed/vmlinux.

Rootfs

In most cases, you will want to give the VM a virtual block device to use as a root file system:

$ crosvm run -r "${ROOT_IMAGE}" "${KERNEL_PATH}"

The root image must be a path to a disk image formatted in a way that the kernel can read. Typically this is a squashfs image made with mksquashfs or an ext4 image made with mkfs.ext4. By using the -r argument, the kernel is automatically told to use that image as the root, and therefore can only be given once. More disks can be given with -d or --rwdisk if a writable disk is desired.

To run crosvm with a writable rootfs:

WARNING: Writable disks are at risk of corruption by a malicious or malfunctioning guest OS.

crosvm run --rwdisk "${ROOT_IMAGE}" -p "root=/dev/vda" vmlinux

NOTE: If more disks arguments are added prior to the desired rootfs image, the root=/dev/vda must be adjusted to the appropriate letter.

Control Socket

If the control socket was enabled with -s, the main process can be controlled while crosvm is running. To tell crosvm to stop and exit, for example:

NOTE: If the socket path given is for a directory, a socket name underneath that path will be generated based on crosvm's PID.

$ crosvm run -s /run/crosvm.sock ${USUAL_CROSVM_ARGS}
    <in another shell>
$ crosvm stop /run/crosvm.sock

WARNING: The guest OS will not be notified or gracefully shutdown.

This will cause the original crosvm process to exit in an orderly fashion, allowing it to clean up any OS resources that might have stuck around if crosvm were terminated early.

Multiprocess Mode

By default crosvm runs in multiprocess mode. Each device that supports running inside of a sandbox will run in a jailed child process of crosvm. The appropriate minijail seccomp policy files must be present either in /usr/share/policy/crosvm or in the path specified by the --seccomp-policy-dir argument. The sandbox can be disabled for testing with the --disable-sandbox option.

Virtio Wayland

Virtio Wayland support requires special support on the part of the guest and as such is unlikely to work out of the box unless you are using a Chrome OS kernel along with a termina rootfs.

To use it, ensure that the XDG_RUNTIME_DIR enviroment variable is set and that the path $XDG_RUNTIME_DIR/wayland-0 points to the socket of the Wayland compositor you would like the guest to use.

Defaults

The following are crosvm's default arguments and how to override them.

  • 256MB of memory (set with -m)
  • 1 virtual CPU (set with -c)
  • no block devices (set with -r, -d, or --rwdisk)
  • no network (set with --host_ip, --netmask, and --mac)
  • virtio wayland support if XDG_RUNTIME_DIR enviroment variable is set (disable with --no-wl)
  • only the kernel arguments necessary to run with the supported devices (add more with -p)
  • run in multiprocess mode (run in single process mode with --disable-sandbox)
  • no control socket (set with -s)

System Requirements

A Linux kernel with KVM support (check for /dev/kvm) is required to run crosvm. In order to run certain devices, there are additional system requirements:

  • virtio-wayland - The memfd_create syscall, introduced in Linux 3.17, and a Wayland compositor.
  • vsock - Host Linux kernel with vhost-vsock support, introduced in Linux 4.8.
  • multiprocess - Host Linux kernel with seccomp-bpf and Linux namespacing support.
  • virtio-net - Host Linux kernel with TUN/TAP support (check for /dev/net/tun) and running with CAP_NET_ADMIN privileges.

Emulated Devices

Device Description
CMOS/RTC Used to get the current calendar time.
i8042 Used by the guest kernel to exit crosvm.
serial x86 I/O port driven serial devices that print to stdout and take input from stdin.
virtio-block Basic read/write block device.
virtio-net Device to interface the host and guest networks.
virtio-rng Entropy source used to seed guest OS's entropy pool.
virtio-vsock Enabled VSOCKs for the guests.
virtio-wayland Allowed guest to use host Wayland socket.

Contributing

Code Health

build_test

There are no automated tests run before code is committed to crosvm. In order to maintain sanity, please execute build_test before submitting code for review. All tests should be passing or ignored and there should be no compiler warnings or errors. All supported architectures are built, but only tests for x86_64 are run. In order to build everything without failures, sysroots must be supplied for each architecture. See build_test -h for more information.

rustfmt

All code should be formatted with rustfmt. Run cargo fmt --all to autoformat your code before checking in a change.

Dependencies

With a few exceptions, external dependencies inside of the Cargo.toml files are not allowed. The reason being that community made crates tend to explode the binary size by including dozens of transitive dependencies. All these dependencies also must be reviewed to ensure their suitability to the crosvm project. Currently allowed crates are:

  • byteorder - A very small library used for endian swaps.
  • cc - Build time dependency needed to build C source code used in crosvm.
  • libc - Required to use the standard library, this crate is a simple wrapper around libc's symbols.

Code Overview

The crosvm source code is written in Rust and C. To build, crosvm generally requires the most recent stable version of rustc.

Source code is organized into crates, each with their own unit tests. These crates are:

  • crosvm - The top-level binary front-end for using crosvm.
  • devices - Virtual devices exposed to the guest OS.
  • io_jail - Creates jailed process using libminijail.
  • kernel_loader - Loads elf64 kernel files to a slice of memory.
  • kvm_sys - Low-level (mostly) auto-generated structures and constants for using KVM.
  • kvm - Unsafe, low-level wrapper code for using kvm_sys.
  • net_sys - Low-level (mostly) auto-generated structures and constants for creating TUN/TAP devices.
  • net_util - Wrapper for creating TUN/TAP devices.
  • sys_util - Mostly safe wrappers for small system facilities such as eventfd or syslog.
  • syscall_defines - Lists of syscall numbers in each architecture used to make syscalls not supported in libc.
  • vhost - Wrappers for creating vhost based devices.
  • virtio_sys - Low-level (mostly) auto-generated structures and constants for interfacing with kernel vhost support.
  • vm_control - IPC for the VM.
  • x86_64 - Support code specific to 64 bit intel machines.

The seccomp folder contains minijail seccomp policy files for each sandboxed device. Because some syscalls vary by architecture, the seccomp policies are split by architecture.