mirror of
https://chromium.googlesource.com/crosvm/crosvm
synced 2024-11-25 05:03:05 +00:00
372118c8aa
Disallow code emitting warnings in run_tests instead of .cargo/config.toml. There are three places where we can specify "-Dwarnings": (1). rustflags in .cargo/config.toml (2). flags in health-check (3). RUSTFLAGS environment variable used in run_tests (1) was the place where we had -Dwarnings, but this affects downstream projects that use cargo. So, it can cause an unexpected build error when unsupported combinations of feature flags are used in the downstream project. So, we want to force "-Dwarnings" only in the upstream CI. (2) is a place we already have the flag. However, the health-check script only runs on x86_64 platform in our CI. So, we choose (3) in this CL so we can force "-Dwarnings" only for fixed sets of features used in the upstream CI. Also, this can support all of platforms in the upstream CI. BUG=b:181763000 TEST=CQ Change-Id: Iceededcc51e19d6781758e7fd7d5a2d7941d9ebc Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4014329 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Commit-Queue: Daniel Verkamp <dverkamp@chromium.org> Reviewed-by: Dennis Kempin <denniskempin@google.com> |
||
---|---|---|
.. | ||
config.toml |