No description
Find a file
Alex Lau 38e8750176 device: virtio: video: Add dead_code attribute to SetControl
BUG=b:161774071
TEST=None

Change-Id: Ia9c9ba1a316a409c17ac601e94bd3f6a75b24af5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2355847
Tested-by: Alex Lau <alexlau@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Keiichi Watanabe <keiichiw@chromium.org>
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
2020-08-18 11:54:02 +00:00
aarch64 Use hypervisor abstraction to run VMs 2020-08-11 04:51:34 +00:00
acpi_tables acpi: support user provided ACPI SDTs. 2020-06-01 23:25:39 +00:00
arch Use hypervisor abstraction to run VMs 2020-08-11 04:51:34 +00:00
assertions edition: Remove extern crate lines 2019-04-15 02:06:08 -07:00
base Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
bin docker: upgrade to Rust 1.45.2 2020-08-11 00:50:48 +00:00
bit_field Update syn, quote, and proc-macro past 1.0 2020-02-06 05:28:15 +00:00
cros_async cros_async: Fix reference to mem being dropped early 2020-08-13 00:04:56 +00:00
crosvm_plugin Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
data_model sys_util: Fix all the default clippy warnings 2020-08-06 03:28:13 +00:00
devices device: virtio: video: Add dead_code attribute to SetControl 2020-08-18 11:54:02 +00:00
disk disk: qcow: fix unit test build on 32-bit platforms 2020-08-18 05:30:36 +00:00
docker docker: upgrade to Rust 1.45.2 2020-08-11 00:50:48 +00:00
docs io_jail: Remove now that the code lives in aosp/external/minijail 2020-06-26 17:27:44 +00:00
enumn crosvm: Fix clippy::needless_doctest_main 2020-07-21 13:18:10 +00:00
fuzz Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
gpu_buffer Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
gpu_display Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
gpu_renderer gpu_renderer: remove redundant -> () from fns 2020-08-13 01:28:52 +00:00
hypervisor Use hypervisor abstraction to run VMs 2020-08-11 04:51:34 +00:00
io_uring Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
kernel_cmdline tree-wide: update to new inclusive range syntax 2019-07-24 02:22:21 +00:00
kernel_loader Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
kokoro add docker supported builds and tests 2019-05-15 13:36:19 -07:00
kvm Use hypervisor abstraction to run VMs 2020-08-11 04:51:34 +00:00
kvm_sys Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
linux_input_sys Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
msg_socket Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
net_sys Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
net_util Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
p9 p9: fix lcreate to respect the open mode 2020-07-15 22:15:14 +00:00
protos protos: add arch = x86 guards around CPUID helpers 2020-08-18 05:30:38 +00:00
qcow_utils Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
rand_ish rand_ish: Generate random string from SimpleRng 2020-06-24 06:44:56 +00:00
resources Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
seccomp tpm: Update libtpm2 to master 2020-07-24 08:08:21 +00:00
src Use hypervisor abstraction to run VMs 2020-08-11 04:51:34 +00:00
sync sync: add wait_timeout method to condvar wrapper 2019-09-16 17:18:28 +00:00
sys_util sys_util: Log to logd via liblog on Android. 2020-08-18 06:20:00 +00:00
syscall_defines Update x86 and x86_64 syscalls to Linux v5.6-rc5, avoiding duplicates. 2020-06-25 14:34:32 +00:00
tempfile sys_util: Fix all the default clippy warnings 2020-08-06 03:28:13 +00:00
tests Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
tpm2 crosvm: add license blurb to all files 2019-04-24 15:51:38 -07:00
tpm2-sys tpm: Update libtpm2 to master 2020-07-24 08:08:21 +00:00
usb_sys Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
usb_util Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
vfio_sys Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
vhost Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
virtio_sys Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
vm_control Use hypervisor abstraction to run VMs 2020-08-11 04:51:34 +00:00
vm_memory Add "base" crate and transition crosvm usages to it from sys_util 2020-08-06 18:19:44 +00:00
x86_64 Use hypervisor abstraction to run VMs 2020-08-11 04:51:34 +00:00
.dockerignore add docker supported builds and tests 2019-05-15 13:36:19 -07:00
.gitignore gitignore: Remove Cargo.lock 2017-06-17 01:12:44 -07:00
.gitmodules tpm: Add tpm2-sys crate 2019-01-13 03:23:13 -08:00
.rustfmt.toml Add basic rustfmt config 2018-09-15 20:58:19 -07:00
build_test add build_test script to automate crosvm test running 2017-09-01 12:39:19 -07:00
build_test.py Use hypervisor abstraction to run VMs 2020-08-11 04:51:34 +00:00
Cargo.lock sys_util: Log to logd via liblog on Android. 2020-08-18 06:20:00 +00:00
Cargo.toml Use hypervisor abstraction to run VMs 2020-08-11 04:51:34 +00:00
CONTRIBUTING.md flesh out high level documentation 2020-01-22 19:10:45 +00:00
LICENSE add LICENSE and README 2017-04-17 14:06:21 -07:00
navbar.md flesh out high level documentation 2020-01-22 19:10:45 +00:00
OWNERS crosvm: update OWNERS to * 2019-11-06 21:09:04 +00:00
PRESUBMIT.cfg crosvm: Add a pre-upload hook to run clippy 2020-07-28 16:29:06 +00:00
README.md readme: add a note about clippy 2020-07-14 17:29:57 +00:00
rust-toolchain rust-toolchain: Change to stable 2019-10-16 22:12:41 +00:00

crosvm - The Chrome OS Virtual Machine Monitor

This component, known as crosvm, runs untrusted operating systems along with virtualized devices. This only runs VMs through the Linux's KVM interface. What makes crosvm unique is a focus on safety within the programming language and a sandbox around the virtual devices to protect the kernel from attack in case of an exploit in the devices.

IRC

The channel #crosvm on freenode is used for technical discussion related to crosvm development and integration.

Getting started

Building for CrOS

crosvm on Chromium OS is built with Portage, so it follows the same general workflow as any cros_workon package. The full package name is chromeos-base/crosvm.

See the Chromium OS developer guide for more on how to build and deploy with Portage.

Building with Docker

See the README from the docker subdirectory to learn how to build crosvm in enviroments outside of the Chrome OS chroot.

Building for Linux

NOTE: Building for Linux natively is new and not fully supported.

First, set up depot_tools and use repo to sync down the crosvm source tree. This is a subset of the entire Chromium OS manifest with just enough repos to build crosvm.

mkdir crosvm
cd crosvm
repo init -g crosvm -u https://chromium.googlesource.com/chromiumos/manifest.git --repo-url=https://chromium.googlesource.com/external/repo.git
repo sync

A basic crosvm build links against libcap and libfdt. On a Debian-based system, you can install libcap-dev and libfdt-dev.

Handy Debian one-liner for all build and runtime deps, particularly if you're running Crostini:

sudo apt install build-essential libcap-dev libfdt-dev pkg-config python

Known issues:

  • Seccomp policy files have hardcoded absolute paths. You can either fix up the paths locally, or set up an awesome hacky symlink: sudo mkdir /usr/share/policy && sudo ln -s /path/to/crosvm/seccomp/x86_64 /usr/share/policy/crosvm. We'll eventually build the precompiled policies into the crosvm binary.
  • Devices can't be jailed if /var/empty doesn't exist. sudo mkdir -p /var/empty to work around this for now.
  • You need read/write permissions for /dev/kvm to run tests or other crosvm instances. Usually it's owned by the kvm group, so sudo usermod -a -G kvm $USER and then log out and back in again to fix this.
  • Some other features (networking) require CAP_NET_ADMIN so those usually need to be run as root.

And that's it! You should be able to cargo build/run/test.

Usage

To see the usage information for your version of crosvm, run crosvm or crosvm run --help.

Boot a Kernel

To run a very basic VM with just a kernel and default devices:

$ crosvm run "${KERNEL_PATH}"

The uncompressed kernel image, also known as vmlinux, can be found in your kernel build directory in the case of x86 at arch/x86/boot/compressed/vmlinux.

Rootfs

In most cases, you will want to give the VM a virtual block device to use as a root file system:

$ crosvm run -r "${ROOT_IMAGE}" "${KERNEL_PATH}"

The root image must be a path to a disk image formatted in a way that the kernel can read. Typically this is a squashfs image made with mksquashfs or an ext4 image made with mkfs.ext4. By using the -r argument, the kernel is automatically told to use that image as the root, and therefore can only be given once. More disks can be given with -d or --rwdisk if a writable disk is desired.

To run crosvm with a writable rootfs:

WARNING: Writable disks are at risk of corruption by a malicious or malfunctioning guest OS.

crosvm run --rwdisk "${ROOT_IMAGE}" -p "root=/dev/vda" vmlinux

NOTE: If more disks arguments are added prior to the desired rootfs image, the root=/dev/vda must be adjusted to the appropriate letter.

Control Socket

If the control socket was enabled with -s, the main process can be controlled while crosvm is running. To tell crosvm to stop and exit, for example:

NOTE: If the socket path given is for a directory, a socket name underneath that path will be generated based on crosvm's PID.

$ crosvm run -s /run/crosvm.sock ${USUAL_CROSVM_ARGS}
    <in another shell>
$ crosvm stop /run/crosvm.sock

WARNING: The guest OS will not be notified or gracefully shutdown.

This will cause the original crosvm process to exit in an orderly fashion, allowing it to clean up any OS resources that might have stuck around if crosvm were terminated early.

Multiprocess Mode

By default crosvm runs in multiprocess mode. Each device that supports running inside of a sandbox will run in a jailed child process of crosvm. The appropriate minijail seccomp policy files must be present either in /usr/share/policy/crosvm or in the path specified by the --seccomp-policy-dir argument. The sandbox can be disabled for testing with the --disable-sandbox option.

Virtio Wayland

Virtio Wayland support requires special support on the part of the guest and as such is unlikely to work out of the box unless you are using a Chrome OS kernel along with a termina rootfs.

To use it, ensure that the XDG_RUNTIME_DIR enviroment variable is set and that the path $XDG_RUNTIME_DIR/wayland-0 points to the socket of the Wayland compositor you would like the guest to use.

Defaults

The following are crosvm's default arguments and how to override them.

  • 256MB of memory (set with -m)
  • 1 virtual CPU (set with -c)
  • no block devices (set with -r, -d, or --rwdisk)
  • no network (set with --host_ip, --netmask, and --mac)
  • virtio wayland support if XDG_RUNTIME_DIR enviroment variable is set (disable with --no-wl)
  • only the kernel arguments necessary to run with the supported devices (add more with -p)
  • run in multiprocess mode (run in single process mode with --disable-sandbox)
  • no control socket (set with -s)

System Requirements

A Linux kernel with KVM support (check for /dev/kvm) is required to run crosvm. In order to run certain devices, there are additional system requirements:

  • virtio-wayland - The memfd_create syscall, introduced in Linux 3.17, and a Wayland compositor.
  • vsock - Host Linux kernel with vhost-vsock support, introduced in Linux 4.8.
  • multiprocess - Host Linux kernel with seccomp-bpf and Linux namespacing support.
  • virtio-net - Host Linux kernel with TUN/TAP support (check for /dev/net/tun) and running with CAP_NET_ADMIN privileges.

Emulated Devices

Device Description
CMOS/RTC Used to get the current calendar time.
i8042 Used by the guest kernel to exit crosvm.
serial x86 I/O port driven serial devices that print to stdout and take input from stdin.
virtio-block Basic read/write block device.
virtio-net Device to interface the host and guest networks.
virtio-rng Entropy source used to seed guest OS's entropy pool.
virtio-vsock Enabled VSOCKs for the guests.
virtio-wayland Allowed guest to use host Wayland socket.

Contributing

Code Health

build_test

There are no automated tests run before code is committed to crosvm. In order to maintain sanity, please execute build_test before submitting code for review. All tests should be passing or ignored and there should be no compiler warnings or errors. All supported architectures are built, but only tests for x86_64 are run. In order to build everything without failures, sysroots must be supplied for each architecture. See build_test -h for more information.

rustfmt

All code should be formatted with rustfmt. We have a script that applies rustfmt to all Rust code in the crosvm repo: please run bin/fmt before checking in a change. This is different from cargo fmt --all which formats multiple crates but a single workspace only; crosvm consists of multiple workspaces.

clippy

The clippy linter is used to check for common Rust problems. The crosvm project uses a specific set of clippy checks; please run bin/clippy before checking in a change.

Dependencies

With a few exceptions, external dependencies inside of the Cargo.toml files are not allowed. The reason being that community made crates tend to explode the binary size by including dozens of transitive dependencies. All these dependencies also must be reviewed to ensure their suitability to the crosvm project. Currently allowed crates are:

  • cc - Build time dependency needed to build C source code used in crosvm.
  • libc - Required to use the standard library, this crate is a simple wrapper around libc's symbols.

Code Overview

The crosvm source code is written in Rust and C. To build, crosvm generally requires the most recent stable version of rustc.

Source code is organized into crates, each with their own unit tests. These crates are:

  • crosvm - The top-level binary front-end for using crosvm.
  • devices - Virtual devices exposed to the guest OS.
  • kernel_loader - Loads elf64 kernel files to a slice of memory.
  • kvm_sys - Low-level (mostly) auto-generated structures and constants for using KVM.
  • kvm - Unsafe, low-level wrapper code for using kvm_sys.
  • net_sys - Low-level (mostly) auto-generated structures and constants for creating TUN/TAP devices.
  • net_util - Wrapper for creating TUN/TAP devices.
  • sys_util - Mostly safe wrappers for small system facilities such as eventfd or syslog.
  • syscall_defines - Lists of syscall numbers in each architecture used to make syscalls not supported in libc.
  • vhost - Wrappers for creating vhost based devices.
  • virtio_sys - Low-level (mostly) auto-generated structures and constants for interfacing with kernel vhost support.
  • vm_control - IPC for the VM.
  • x86_64 - Support code specific to 64 bit intel machines.

The seccomp folder contains minijail seccomp policy files for each sandboxed device. Because some syscalls vary by architecture, the seccomp policies are split by architecture.