mirror of
https://chromium.googlesource.com/crosvm/crosvm
synced 2024-11-28 09:33:01 +00:00
69c7b3bf78
Filter riscv crates that can't yet build so clippy can run on those that do. Change-Id: I43ddd5ab6c12a42812949d552037a35a1e928296 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4505758 Commit-Queue: Dennis Kempin <denniskempin@google.com> Reviewed-by: Dennis Kempin <denniskempin@google.com>
61 lines
1.6 KiB
Python
Executable file
61 lines
1.6 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright 2019 The ChromiumOS Authors
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
# To check for violations:
|
|
# $ ./tools/clippy
|
|
#
|
|
# To fix violations where possible:
|
|
# $ ./tools/clippy --fix
|
|
|
|
from typing import Optional
|
|
from impl.common import CROSVM_ROOT, run_main, cmd, chdir, Triple, SHORTHANDS
|
|
from impl.test_config import DO_NOT_BUILD_RISCV64
|
|
|
|
clippy = cmd("cargo clippy").with_color_flag()
|
|
|
|
|
|
def main(
|
|
fix: bool = False,
|
|
json: bool = False,
|
|
locked: bool = False,
|
|
platform: Optional[str] = None,
|
|
):
|
|
try:
|
|
triple: Triple = Triple.from_shorthand(platform) if platform else Triple.host_default()
|
|
except Exception as e:
|
|
raise type(e)(str(e) + f"\nValid platforms are {', '.join(SHORTHANDS.keys())}")
|
|
|
|
chdir(CROSVM_ROOT)
|
|
|
|
# Note: Clippy checks are configured in .cargo/config.toml
|
|
common_args = [
|
|
"--message-format=json" if json else None,
|
|
"--locked" if locked else None,
|
|
"--all-targets",
|
|
"--",
|
|
"-Dwarnings",
|
|
]
|
|
if fix:
|
|
common_args = [
|
|
"--fix",
|
|
"--allow-no-vcs",
|
|
"--allow-dirty",
|
|
"--allow-staged",
|
|
*common_args,
|
|
]
|
|
print("Clippy crosvm workspace")
|
|
exclude_args = []
|
|
if triple == Triple.from_shorthand("riscv64"):
|
|
exclude_args = ["--exclude=" + s for s in DO_NOT_BUILD_RISCV64]
|
|
clippy(
|
|
"--workspace",
|
|
f"--features={triple.feature_flag}",
|
|
*exclude_args,
|
|
*common_args,
|
|
).with_envs(triple.get_cargo_env()).fg()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
run_main(main)
|