mirror of
https://chromium.googlesource.com/crosvm/crosvm
synced 2024-11-28 17:44:10 +00:00
293913c01a
rutabaga_gralloc is a cross-platform, Rust-based buffer manager. The rationale for this change is: 1) For the {cross-domain, wayland} context type, we need to have a good story for the crucial "wl-dmabuf" feature. As minigbm has been thoroughly tested on ChromeOS and currently powers the "wl-dmabuf" feature, it only makes sense for us to have a path to minigbm for the cross-domain prototype. This will be used by Sommelier. 2) While minigbm allocation works well on Chromebooks, it is not sufficient for cross-platform purposes. For their Virtual Graphics Interface (VGI) initiative, Android graphics virtualization experts have expressed their desire for a Vulkan based allocator. This will to go alongside cros_gralloc in minigbm, which is considered by many to be the ""world's premiere gralloc implementation". 3) Android graphics virtualization experts have expressed their desire for vkMapMemory(..) to be used when crosvm is in multi-process mode. Currently, only dma-buf mmap() is supported for zero-copy blobs in multi-process mode. dma-buf mmap() is not guaranteed to work on Nvidia (a "must have" for Cuttlefish) or any other driver for that matter (we *make* it work for ChromeOS). Possibly only solution: vkMapMemory ;-) With these goals in mind, here's a summary of the revelant changes: * Renamed the {gpu_allocator.rs, GpuMemoryAllocator trait} to be {gralloc.rs, Gralloc trait}. * Moved all GPU allocation out of the resources crate and into the rutabaga_gfx crate. This will allow the resources crate to be focused on managing resources for virtual machines. * Moved the gpu_buffer crate into the gralloc module in the rutabaga_gfx crate. The same functionality is now under "minigbm.rs", "minigbm_bindings.rs" and "rendernode.rs" * Added an optional dependency on vulkano.rs. vulkano.rs is a safe Rust wrapper around the Vulkan api [a]. It's emphasis on type safety makes a good fit for crosvm, though there are other high quality crates out there (gfx-rs, ash.rs). Though development has slowed down, it should satisfy goals (2) and (3) quite easily. * Added a system_gralloc implementation based on memfd. This can be used when minigbm or Vulkano features are not used, to replicate the highly useful "wl-shm" feature in Sommelier. Astute observers will note this can also enable seamless Wayland windowing without GPU features for Android too. Some minor changes to the base crate were needed. * Cut down on the amount of DrmFormats to the subset needed by Sommelier and cros_gralloc. * Moved checked arithmetic into it's own file. * Internally renamed to "wl-dmabuf" feature to be the "minigbm" feature. This is because "wl-dmabuf" has a dependency on minigbm. * Small rutabaga_gfx cleanups [a] https://github.com/vulkano-rs/vulkano/blob/master/DESIGN.md BUG=b:146066070, b:173630595, b:150239451 TEST=launch virtual machine with 2D mode TEST=launch virtual machine with 3D mode TEST=run sommelier with "wl-dmabuf" and "wl-shm" Change-Id: I693a39cef64cd98e56d843d3c60caa7983d4d6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2626487 Tested-by: Gurchetan Singh <gurchetansingh@chromium.org> Reviewed-by: Zach Reizner <zachr@chromium.org> Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org> |
||
---|---|---|
.. | ||
src | ||
Cargo.toml |