From 121b86c89c1e5b6441a06ba611c409db8a7e88f6 Mon Sep 17 00:00:00 2001 From: Martin von Zweigbergk Date: Sun, 12 Mar 2023 10:29:45 -0700 Subject: [PATCH] tests: remove an obsolete TODO about unreachable commits in index I don't think there's much to gain from making the index match exactly what's reachable from the view. FWIW, our cloud-based implementation at Google will probably make everyone's commits visible in the index regardless of which operation they're at. --- lib/tests/test_mut_repo.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/tests/test_mut_repo.rs b/lib/tests/test_mut_repo.rs index 3fb51bf5d..09005038f 100644 --- a/lib/tests/test_mut_repo.rs +++ b/lib/tests/test_mut_repo.rs @@ -335,10 +335,6 @@ fn test_remove_head(use_git: bool) { // Test that MutableRepo::remove_head() removes the head, and that it's still // removed after commit. It should remain in the index, since we otherwise would // have to reindex everything. - // TODO: Consider if it's better to have the index be exactly the commits - // reachable from the view's heads. We would probably want to add tombstones - // for commits no longer visible in that case so we don't have to reindex e.g. - // when the user does `jj op undo`. let settings = testutils::user_settings(); let test_repo = TestRepo::init(use_git); let repo = &test_repo.repo;