From 1be82250460a914ba2c718260de32d2c9eb60f9d Mon Sep 17 00:00:00 2001 From: Martin von Zweigbergk Date: Tue, 6 Feb 2024 13:40:05 -0800 Subject: [PATCH] docs: explain that approving your coworker's PRs should be avoided We want to avoid conflicts of interest (both real and apparent). Better to document this before it happens. By the way, Ilya and I both work for Google and we have approved lots of each others' PRs, but we work in very different parts of the company and I don't think any of the PRs have been specific to Google's interests. --- docs/contributing.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/contributing.md b/docs/contributing.md index 03b2d1e2e..8c989fb54 100644 --- a/docs/contributing.md +++ b/docs/contributing.md @@ -51,6 +51,12 @@ so you can address any remaining minor comments and then merge the PR yourself when you're ready. If you realize that some comments require non-trivial changes, please ask your reviewer to take another look. +To avoid conflicts of interest, please don't merge a PR that has only been +approved by someone from the same organization. Similarly, as a reviewer, +there is no need to approve your coworkers' PRs, since the author should await +an approval from someone else anyway. It is of course still appreciated if you +review and comment on their PRs. Also, if the PR seems completely unrelated to +your company's interests, do feel free to approve it. ### Community Guidelines