From e721a81780d70e39a4e59c0eb95b4a5dd7464a28 Mon Sep 17 00:00:00 2001 From: Martin von Zweigbergk Date: Sun, 19 Mar 2023 16:47:16 -0700 Subject: [PATCH] revset: update documentation of `Revset::iter()` Since we hid the graph iterator implementation behind `Revset::iter_graph()`, I don't think we have any callers of `Revset::iter()` require the iteration to be in index position order, so let's not promise that. We do want to promise that the iteration is in topological order with children before parents, however. --- lib/src/revset.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/src/revset.rs b/lib/src/revset.rs index 140915856..712f08b4c 100644 --- a/lib/src/revset.rs +++ b/lib/src/revset.rs @@ -1556,7 +1556,7 @@ pub fn resolve_symbols( } pub trait Revset<'index> { - // All revsets currently iterate in order of descending index position + /// Iterate in topological order with children before parents. fn iter(&self) -> Box> + '_>; fn iter_graph(