From f1e91cdab5638ac24f78c65f9a521c9475d6e6db Mon Sep 17 00:00:00 2001
From: Jakob Hellermann <jakob.hellermann@protonmail.com>
Date: Fri, 10 Jan 2025 23:21:54 +0100
Subject: [PATCH] cli: complete: fix stderr during autocomplete of revsets

When running `cmd.spawn()` rust will by default inherit
the stderr of the parent, so `jj log test<TAB>`, would
print `There is no jj repo in "."` into the prompt.
---
 cli/src/complete.rs          | 1 +
 cli/tests/test_completion.rs | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/cli/src/complete.rs b/cli/src/complete.rs
index 83e95cdc5..08611c9b6 100644
--- a/cli/src/complete.rs
+++ b/cli/src/complete.rs
@@ -472,6 +472,7 @@ fn all_files_from_rev(rev: String, current: &std::ffi::OsStr) -> Vec<CompletionC
             .arg("--config=ui.allow-filesets=true")
             .arg(current_prefix_to_fileset(current))
             .stdout(std::process::Stdio::piped())
+            .stderr(std::process::Stdio::null())
             .spawn()
             .map_err(user_error)?;
         let stdout = child.stdout.take().unwrap();
diff --git a/cli/tests/test_completion.rs b/cli/tests/test_completion.rs
index 66c1015c7..0b90f4806 100644
--- a/cli/tests/test_completion.rs
+++ b/cli/tests/test_completion.rs
@@ -819,4 +819,8 @@ fn test_files() {
     f_not_yet_renamed
     f_unchanged
     ");
+
+    let outside_repo = test_env.env_root();
+    let stdout = test_env.jj_cmd_success(outside_repo, &["--", "jj", "log", "f_"]);
+    insta::assert_snapshot!(stdout, @r"");
 }