663 commits

Author	SHA1	Message	Date
Anton Bulakh	c99c97c646	sign: Add templater methods to show signature info ... Disclaimer: this is the work of @necauqua and @julienvincent (see #3141). I simply materialized the changes by rebasing them on latest `main` and making the necessary adjustments to pass CI. --- I had to fix an issue in `TestSignatureBackend::sign()`. The following test was failing: ``` ---- test_signature_templates::test_signature_templates stdout ---- ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot: signature_templates Source: cli/tests/test_signature_templates.rs:28 ──────────────────────────────────────────────────────────────────────────────── Expression: stdout ──────────────────────────────────────────────────────────────────────────────── -old snapshot +new results ────────────┬─────────────────────────────────────────────────────────────────── 0 0 │ @ Commit ID: 05ac066d05701071af20e77506a0f2195194cbc9 1 1 │ │ Change ID: qpvuntsmwlqtpsluzzsnyyzlmlwvmlnu 2 2 │ │ Author: Test User <test.user@example.com> (2001-02-03 08:05:07) 3 3 │ │ Committer: Test User <test.user@example.com> (2001-02-03 08:05:07) 4 │-│ Signature: Good test signature 4 │+│ Signature: Bad test signature 5 5 │ │ 6 6 │ │ (no description set) 7 7 │ │ 8 8 │ ◆ Commit ID: 0000000000000000000000000000000000000000 ────────────┴─────────────────────────────────────────────────────────────────── ``` Print debugging revealed that the signature was bad, because of a missing trailing `\n` in `TestSignatureBackend::sign()`. ```diff diff --git a/lib/src/test_signing_backend.rs b/lib/src/test_signing_backend.rs index d47fef1086..0ba249e358 100644 --- a/lib/src/test_signing_backend.rs +++ b/lib/src/test_signing_backend.rs @@ -59,6 +59,8 @@ let key = (!key.is_empty()).then_some(std::str::from_utf8(key).unwrap().to_owned()); let sig = self.sign(data, key.as_deref())?; + dbg!(&std::str::from_utf8(&signature).unwrap()); + dbg!(&std::str::from_utf8(&sig).unwrap()); if sig == signature { Ok(Verification::new( SigStatus::Good, ``` ``` [lib/src/test_signing_backend.rs:62:9] &std::str::from_utf8(&signature).unwrap() = \"--- JJ-TEST-SIGNATURE ---\\nKEY: \\n5300977ff3ecda4555bd86d383b070afac7b7459c07f762af918943975394a8261d244629e430c8554258904f16dd9c18d737f8969f2e7d849246db0d93cc004\\n\" [lib/src/test_signing_backend.rs:63:9] &std::str::from_utf8(&sig).unwrap() = \"--- JJ-TEST-SIGNATURE ---\\nKEY: \\n5300977ff3ecda4555bd86d383b070afac7b7459c07f762af918943975394a8261d244629e430c8554258904f16dd9c18d737f8969f2e7d849246db0d93cc004\" ``` Thankfully, @yuja pointed out that libgit2 appends a trailing newline (see bfb7613d5d). Co-authored-by: necauqua <him@necauq.ua> Co-authored-by: julienvincent <m@julienvincent.io>	2025-01-04 13:24:08 +01:00
blinry	1ddfc59ee9	docs: Use "branch" consistently when talking about Git's branches ... Some places used "bookmark" instead, which makes it harder to differentiate between jj's and Git's differing concepts.	2025-01-03 10:54:00 -06:00
Ollivier Robert	602b79f7fd	Add a paragraph on how to install jj completions into Powershell. ... Change USER into $HOME.	2025-01-02 10:52:55 -06:00
umnikos	ecbee49bf4	docs: fix typo in builtin_immutable_heads() description	2024-12-31 19:24:36 -06:00
Waleed Khan	34ec85edbd	docs: revert "docs: update installation docs to say that cmake is needed" ... This reverts commit b7ba3fc0be. As per discussion in https://github.com/martinvonz/jj/pull/5047, I would like to make it so that the default build configuration doesn't need `cmake`.	2024-12-31 17:07:52 -06:00
Scott Taylor	0dbcdf7233	docs: explain long conflict markers	2024-12-25 20:34:40 -06:00
Bryce Berger	1d3c3b8ab2	describe: ignore everything below ignore-rest line ... This implements "scissor" lines. For example: this text is included in the commit message JJ: ignore-rest this text is not, and is encouraged to be rendered as a diff JJ: ignore-rest this text is *still not* included in the commit message When editing multiple commit messages, the `JJ: describe {}` lines are parsed before the description is cleaned up. That means that the following will correctly add descriptions to multiple commits: JJ: describe aaaaaaaaaaaa this text is included in the first commit message JJ: ignore-rest scissored... JJ: describe bbbbbbbbbbbb this text is included in the first commit message JJ: ignore-rest scissored...	2024-12-23 16:31:55 -07:00
Scott Taylor	542d09c6a9	merge_tools: add "$marker_length" variable ... Git supports passing the conflict marker length to merge drivers using "%L". It would be useful if we also had a way to pass the marker length to merge tools, since it would allow Git merge drivers to be used with `jj resolve` in more cases. Without this variable, any merge tool that parses or generates conflict markers could fail on files which require conflict markers longer than 7 characters. https://git-scm.com/docs/gitattributes#_defining_a_custom_merge_driver	2024-12-23 08:42:10 -06:00
Tim Janik	e3c8dce06a	docs/config.md: the op log needs a builtin_op_log_* template ... Signed-off-by: Tim Janik <timj@gnu.org>	2024-12-20 06:15:34 +01:00
Jochen Kupperschmidt	07e01c1ba6	docs: Git does not use bookmarks	2024-12-19 20:59:45 -08:00
Yuya Nishihara	89d3a8b8b7	config: remove check for relative path patterns, add doc about path equivalence ... I originally added the check so we would never canonicalize path relative to random cwd, but Windows CI failed because "/" is a relative path. Suppose user would want to share the same configuration file between native Windows and WSL, this check would be too nitpicky.	2024-12-20 09:23:46 +09:00
Yuya Nishihara	f5d450d7c3	cli: resolve conditional config scopes ... This is an alternative way to achieve includeIf of Git without adding "include" directive. Conditional include (or include in general) is a bit trickier to implement than loading all files and filtering the contents. Closes #616	2024-12-19 11:09:02 +09:00
Stephen Jennings	3316180dc1	config: Add commit_timestamp(commit) template alias ... Adds an extension point for changing which date is displayed in log formats. The function should return a timestamp, not a formatted string.	2024-12-18 17:55:03 -08:00
Martin von Zweigbergk	b836e0ae95	docs/cli: update URLs to from martinvonz user to jj-vcs org ... We just migrated to the jj-vcs GitHub org, so we should point to the new GitHub URLs.	2024-12-17 12:44:44 -08:00
scored wrench	2a563039a5	docs: fix incorrect gitignore path	2024-12-17 10:02:55 -08:00
Yuya Nishihara	f87c6ed337	cli: deprecate --config-toml ... Typical usage should now be covered by --config=NAME=VALUE. Closes #3867	2024-12-17 20:12:12 +09:00
Yuya Nishihara	60078e9887	cli: add simpler --config=NAME=VALUE argument ... This supersedes #3867. I'll probably replace all uses of --config-toml and mark --config-toml as deprecated.	2024-12-17 10:33:29 +09:00
Milo Moisson	acaf7afc5b	docs: document JJ_LOG and --debug	2024-12-17 01:51:35 +01:00
Tim Janik	25117d7d01	docs/github.md: Useful Revsets: fix revset for @ ancestry without remotes ... This also fixes a mismatch between using ::@ to list ancestors and calling them descendants. Signed-off-by: Tim Janik <timj@gnu.org>	2024-12-16 21:23:09 +01:00
Benjamin Tan	dc16830151	templater: add Email template type, deprecate Signature.username() ... The `Signature.email()` method is also updated to return the new Email type. The `Signature.username()` method is deprecated for `Signature.email().local()`.	2024-12-15 16:03:34 +08:00
Yuya Nishihara	fca92f1e16	cli: add --config-file=PATH argument ... This would be useful for scripting purpose. Maybe we can also replace the current --config-toml=<TOML> use cases by --config-file=<PATH> and simpler --config=<KEY>=<VALUE>. https://github.com/martinvonz/jj/issues/4926#issuecomment-2506672165 If we want to add more source variants (such as fd number), it might be better to add --config-from=<type>:<path|fd|..>. In any case, we'll probably want --config=<KEY>=<VALUE>, and therefore, we'll need to merge more than one --config* arguments.	2024-12-13 10:27:03 +09:00
Yuya Nishihara	e1ab2477cd	docs: mention "jj file untrack" in Git compatibility list ... Closes #5059	2024-12-13 10:20:48 +09:00
Yuya Nishihara	0f845b6930	docs: quote "jj file untrack" consistently	2024-12-13 10:20:48 +09:00
Austin Seipp	e7e66d23b1	Back out 89d57ffb: "build: add rust-toolchain.toml" ... This backs out commit 89d57ffb29. This is causing a CI failure because we can't build musl binaries, presumably because the rust-toolchain file overriding the chosen musl toolchain for some reason. Backout until we can reapply a proper fix. Signed-off-by: Austin Seipp <aseipp@pobox.com>	2024-12-12 15:54:30 -06:00
Yuya Nishihara	53b8eeb5ab	templater: rename "logical" eq/ne operators ... They are the equality operators. There aren't logical, bitwise, arithmetic thingy.	2024-12-12 22:48:45 +09:00
Benjamin Tan	da5b790f7a	templater: add relational operators (>=, >, <=, <) ... Closes #5062.	2024-12-12 19:56:29 +08:00
Yuya Nishihara	0de36918e4	config: merge and print inline tables as values ... Before, "jj config get"/"list" and .get() functions processed inline tables as tables (or directories in filesystem analogy), whereas "set"/"unset" processed ones as values (or files.) This patch makes all commands and functions process inline tables as values. We rarely use the inline table syntax, and it's very hard to pack many (unrelated) values into an inline table. TOML doesn't allow newlines between { .. }. Our common use case is to define color styles, which wouldn't be meant to inherit attributes from the default settings. The default pager setting is flattened in case user overrides pager.env without changing the command args.	2024-12-12 10:11:51 +09:00
Waleed Khan	c2b86197f5	docs: collapse contributing.md suggested cargo install commands ... Should be easier to copy-and-paste and install everything this way?	2024-12-11 11:05:47 -08:00
Waleed Khan	89d57ffb29	build: add rust-toolchain.toml ... Follow-up from discussion at https://discord.com/channels/968932220549103686/1288926971719323762 I don't think we achieved consensus in that thread. We could use `stable` or `nightly` here instead if we prefer. Note that user `rustup` overrides are still respected in the presence of a `rust-toolchain.toml`.	2024-12-11 11:05:47 -08:00
Yuya Nishihara	e1936a2e8b	docs: suggest "jj bookmark move" where makes sense ... Closes #5067	2024-12-11 10:37:45 +09:00
Waleed Khan	652d16369a	docs: in sparse-v2.md, use Markdown warning admonition ... Renders more nicely on the documentation website.	2024-12-07 13:50:44 -08:00
Waleed Khan	129ea5262f	docs: in contributing.md, use Markdown warning admonition ... This has special rendering on the website, which makes it stand out more clearly.	2024-12-07 13:50:44 -08:00
Martin von Zweigbergk	b7ba3fc0be	docs: update installation docs to say that cmake is needed ... Since we enabled the `zlib-ng` feature from `gix` in 2412fd4, `cmake` is needed when installing from source.	2024-12-06 08:23:27 -08:00
Scott Taylor	fa7d9c09fc	merge_tools: add merge-conflict-exit-codes option ... Some Git merge drivers can partially resolve conflicts, leaving some conflict markers in the output file. In that case, they exit with a code between 1 and 127 to indicate that there was a conflict remaining in the file (since Git uses a shell to run the merge drivers, and shells often use exit codes above 127 for special meanings such as exiting due to a signal): https://git-scm.com/docs/gitattributes#_defining_a_custom_merge_driver We should support this convention as well, since it will allow many Git merge drivers to be used with Jujutsu, but we don't run our merge tools through a shell, so there is no reason to treat exit codes 1 through 127 specially. Instead, we let the user specify which exact exit codes should indicate conflicts. This is also better for cross-platform support, since Windows may use different exit codes than Linux for instance.	2024-12-03 20:08:31 -06:00
Remo Senekowitsch	d76bcd9305	docs: clarify dynamic completion features	2024-11-29 21:22:38 +01:00
Scott Taylor	7f57866332	merge_tools: allow setting conflict marker style per-tool ... I left the "merge-tool-edits-conflict-markers" option unchanged, since removing it would likely break some existing configurations. It also seems like it could be useful to have a merge tool use the default conflict markers instead of requiring the conflict marker style to always be set for the merge tool (e.g. if a merge tool allows the user to manually edit the conflicts).	2024-11-26 09:05:17 -06:00
Scott Taylor	ea72a4af28	tutorial: fix conflict formatting issue	2024-11-25 16:47:59 -06:00
Martin von Zweigbergk	5aee10aa6d	faq: add an entry about why merge commits are often empty	2024-11-25 10:46:52 -08:00
Scott Taylor	472fd35ff1	docs: rewrite conflict marker docs to include new styles ... The current docs for conflict markers start out by introducing Git "diff3" conflict markers, and then discussing how Jujutsu's conflict markers are different from Git's. I don't think this is the best way to explain it, because it requires the reader to first understand Git's conflict markers before they go on to learn Jujutsu's conflict markers. Instead, I think it's better to explain the conflict markers from scratch with a more detailed example so that we don't assume any particular knowledge of Git. This structure also works better with the new config option, since we can talk about the default option first, and then go on to explain alternatives later.	2024-11-23 08:28:47 -06:00
Lars Francke	ffe5519fd0	Update tutorial for 0.23 and clarify diffedit	2024-11-22 21:23:12 +01:00
Tim Janik	86a2a2b1e9	docs/git-compatibility.md: preserve working copy files when co-locating ... Use `jj new && jj undo` instead of `jj new @-` at the end of converting to a co-located repository, because the latter "stashes" newly added working copy changes into a sibling commit. See also: https://github.com/martinvonz/jj/discussions/4945 Signed-off-by: Tim Janik <timj@gnu.org>	2024-11-22 19:20:36 +01:00
Emily	c0a9e20222	docs: tighten the "previewing docs" section	2024-11-20 06:06:53 +01:00
Emily	cedaa5bb00	docs: migrate from poetry to uv ... Our docs are built with MkDocs, which requires Python and several deps. Previously those deps were managed with Poetry, which is also written in Python. This commit replaces Poetry with `uv`, a Rust-based Python project/package manager, and thus removes several steps from the docs build process. Before: <install Python> <install pipx> pipx install poetry poetry install poetry run -- mkdocs serve After: <install uv> uv run mkdocs serve	2024-11-20 06:06:53 +01:00
Luke Randall	068fa0f37e	revset: allow tags() to take a pattern for an argument ... This makes it more consistent with `bookmarks()`. Co-authored-by: Austin Seipp <aseipp@pobox.com>	2024-11-20 00:47:23 +00:00
Herman J. Radtke III	3be6f03938	docs: git blame comparison ... Add comparison for git blame and jj file annotate.	2024-11-19 09:58:28 -08:00
Yuya Nishihara	296961cb19	cli: git push: do not push new bookmarks by default ... If you have multiple remotes to push to, you might want to keep some changes (such as security patches) in your private fork. Git CLI has one upstream remote per branch, but jj supports multiple tracking remotes, and therefore "jj git push" can start tracking new remotes automatically. This patch makes new bookmarks not eligible for push by default. I considered adding a warning, but it's not always possible to interrupt the push shortly after a warning is emitted. --all implies --allow-new because otherwise it's equivalent to --tracked. It's also easier to write a conflict rule with --all/--deleted/--tracked than with two of them. -c/--change doesn't require --allow-new because it is the flag to create new tracking bookmark. #1278	2024-11-19 21:11:22 +09:00
Martin von Zweigbergk	a22620d30c	docs: say that support for Git's remote config is partial ... #4889	2024-11-16 17:41:08 -08:00
Tim Janik	e8bbd89ec1	docs/community_tools.md: add paragraph about jj-fzf ... Signed-off-by: Tim Janik <timj@gnu.org>	2024-11-16 23:49:03 +01:00
Tim Janik	68d4ec7f0a	docs/community_tools.md: restore alphabetical order ... Signed-off-by: Tim Janik <timj@gnu.org>	2024-11-16 23:49:03 +01:00
Martin von Zweigbergk	9fc3255238	docs: try to clarify that changes are not a first-class concept	2024-11-16 14:20:37 -08:00