Martin von Zweigbergk
31041ef46c
github: trigger all builds on main branch, and PR for any branch
...
The conditions for triggering Nix builds and other builds were
slightly different.
Nix builds triggered by PRs happened on PRs for any branch, not just
the `main` branch. That makes very little difference in practice
because PRs for other branches are very rare. Still, let's be
consistent. I decided to trigger the builds on PRs for any branch.
More importantly, Nix builds triggered by push were only done for
pushes to `master`, which is not what our main branch is called, so
those never happened.
2022-05-06 11:56:50 -07:00
Martin von Zweigbergk
ffc57310f6
cargo: upgrade protobuf crates to 3.0.1
...
The biggest difference in the API is that fields are now public. The
exception from that is `oneof` fields, which still require setters and
getters.
I couldn't measure any difference in performance. I didn't expect any
difference either, but it's good that it didn't seem to regress. I
timed `jj debug operation <some hash prefix>`, which will read the
whole operation log (to check that the prefix is unambiguous).
2022-05-04 17:02:11 -07:00
Martin von Zweigbergk
efa77fd024
github: run clippy on all targets (including tests and benches)
2022-05-03 15:41:03 -07:00
Martin von Zweigbergk
cce2ca06e2
github: stop running nightly clippy
...
It seems fine to wait for the clippy lints to graduate before we run
them if we can save a bit of GitHub resources.
2022-05-03 15:41:03 -07:00
dependabot[bot]
6076c01d20
github: bump actions/checkout from 3.0.1 to 3.0.2
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](dcd71f6466...2541b1294d
2022-04-21 09:10:26 -07:00
Martin von Zweigbergk
5e729eced7
github: also run tests on our MSRV (1.58)
...
This patch sets up an additional CI strategy running tests on 1.58, to
make sure we don't accidentally use newer features. I've only made it
run on one platform (Linux) to avoid wasting resources. There's of
course a small risk that we start depending on platform-specific APIs
from newer versions.
2022-04-19 16:47:42 -07:00
dependabot[bot]
32a39c52e1
github: bump actions/checkout from 3.0.0 to 3.0.1
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](a12a3943b4...dcd71f6466
2022-04-15 08:53:12 -07:00
Martin von Zweigbergk
b4e6fab1af
github: restrict Clippy's access again
...
It seems "checks" is the permissions it needs to be able to comment on
pull-requests.
2022-03-18 22:51:25 -07:00
dependabot[bot]
36a575ccbf
github: bump actions-rs/cargo from 1.0.1 to 1.0.3
...
Bumps [actions-rs/cargo](https://github.com/actions-rs/cargo ) from 1.0.1 to 1.0.3.
- [Release notes](https://github.com/actions-rs/cargo/releases )
- [Changelog](https://github.com/actions-rs/cargo/blob/master/CHANGELOG.md )
- [Commits](ae10961054...844f36862e
2022-03-18 08:53:12 -07:00
dependabot[bot]
bde79f7a60
github: bump actions-rs/toolchain from 1.0.6 to 1.0.7
...
Bumps [actions-rs/toolchain](https://github.com/actions-rs/toolchain ) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/actions-rs/toolchain/releases )
- [Changelog](https://github.com/actions-rs/toolchain/blob/master/CHANGELOG.md )
- [Commits](b2417cde72...16499b5e05
2022-03-18 08:45:06 -07:00
Martin von Zweigbergk
23c92ccf45
github: pin actions-rs/clippy-check version by hash
2022-03-17 09:19:12 -07:00
Martin von Zweigbergk
de56053531
github: pin actions-rs/toolchain version by hash
2022-03-17 09:19:12 -07:00
Martin von Zweigbergk
13f7354cfe
github: pin actions-rs/cargo version by hash
2022-03-17 09:19:12 -07:00
Martin von Zweigbergk
b36e50c09d
github: pin actions/checkout version by hash
2022-03-17 09:19:12 -07:00
dependabot[bot]
4fab28ffc6
github: bump actions/checkout from 2 to 3
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-16 22:57:55 -07:00
Martin von Zweigbergk
b5659ec680
github: give Clippy action full permissions
...
I've found it hard to figure out which actions need which
permissions. GitHub doesn't seem to even document what the permissions
mean. So let's just give Clippy full access.
2022-03-16 20:28:54 -07:00
Martin von Zweigbergk
af76631021
github: set top-level permissions to readonly for all workflows
...
The new code scanner is complaining that actions have permissions to
do too much. It wasn't obvious to me what permissions the jobs need,
but let's see how this works.
2022-03-16 19:59:08 -07:00
Martin von Zweigbergk
32e22831fc
github: make CI check formatting
...
I've forgotten to run `rustfmt` many times (most recently in
5721436558
2022-03-07 22:16:57 -08:00
Martin von Zweigbergk
e0cd81cab4
github: use actions-rs/cargo instead of run
...
From https://github.com/actions-rs/cargo#use-cases , it sounds like
errors may be presented in a nicer way if we use `actions-rs/cargo`
instead of a simple `run`, so let's try it.
2022-03-07 22:16:57 -08:00
Martin von Zweigbergk
f112b5225c
github: use minimal profile for clippy actions
...
We should only need the `minimal` profile. Also, we already have
configured the action to use the `clippy` component, so I don't think
we need to explicitly add it with a separate `run` action.
2022-03-07 22:16:57 -08:00
Waleed Khan
38aee9f749
ci: add Clippy stable check
...
Currently, `main` has Clippy lint warnings on stable, but not on nightly.
2022-02-23 23:41:55 -08:00
Waleed Khan
b011805fc7
ci: use stable Rust for builds
...
We still use nightly Clippy to ensure that 1) it builds under nightly and 2) that we pick up any new lints.
2022-02-20 22:21:14 -08:00
Martin von Zweigbergk
079b3543b5
github: set RUST_BACKTRACE when running tests
2021-06-13 22:20:09 -07:00
Martin von Zweigbergk
1941801055
github: add Clippy check to CI
2021-03-23 10:46:10 -07:00
Jun Wu
0fb59a5155
github: setup CI
...
Run tests on major platforms using GitHub actions.
2021-03-14 15:57:54 -07:00
