// Copyright 2022 The Jujutsu Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // https://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. use std::path::Path; use crate::common::TestEnvironment; pub mod common; fn create_commit( test_env: &TestEnvironment, repo_path: &Path, name: &str, parents: &[&str], files: &[(&str, &str)], ) { if parents.is_empty() { test_env.jj_cmd_success(repo_path, &["new", "root", "-m", name]); } else { let mut args = vec!["new", "-m", name]; args.extend(parents); test_env.jj_cmd_success(repo_path, &args); } for (name, content) in files { std::fs::write(repo_path.join(name), content).unwrap(); } test_env.jj_cmd_success(repo_path, &["branch", "create", name]); } fn get_log_output(test_env: &TestEnvironment, repo_path: &Path) -> String { test_env.jj_cmd_success(repo_path, &["log", "-T", "branches"]) } #[test] fn test_resolution() { let mut test_env = TestEnvironment::default(); test_env.jj_cmd_success(test_env.env_root(), &["init", "repo", "--git"]); let repo_path = test_env.env_root().join("repo"); create_commit(&test_env, &repo_path, "base", &[], &[("file", "base\n")]); create_commit(&test_env, &repo_path, "a", &["base"], &[("file", "a\n")]); create_commit(&test_env, &repo_path, "b", &["base"], &[("file", "b\n")]); create_commit(&test_env, &repo_path, "conflict", &["a", "b"], &[]); // Test the setup insta::assert_snapshot!(get_log_output(&test_env, &repo_path), @r###" @ conflict ├─╮ o │ b │ o a ├─╯ o base o "###); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["resolve", "--list"]), @r###" file 2-sided conflict "###); insta::assert_snapshot!( std::fs::read_to_string(repo_path.join("file")).unwrap() , @r###" <<<<<<< %%%%%%% -base +a +++++++ b >>>>>>> "###); let editor_script = test_env.set_up_fake_editor(); // Check that output file starts out empty and resolve the conflict std::fs::write( &editor_script, ["dump editor0", "write\nresolution\n"].join("\0"), ) .unwrap(); insta::assert_snapshot!( test_env.jj_cmd_success(&repo_path, &["resolve"]), @r###" Working copy now at: e069f0736a79 conflict Added 0 files, modified 1 files, removed 0 files "###); insta::assert_snapshot!( std::fs::read_to_string(test_env.env_root().join("editor0")).unwrap(), @r###" "###); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["diff"]), @r###" Resolved conflict in file: 1 1: <<<<<<>>>>>> "###); insta::assert_snapshot!(test_env.jj_cmd_cli_error(&repo_path, &["resolve", "--list"]), @r###" Error: No conflicts found at this revision "###); // Check that the output file starts with conflict markers if // `merge-tool-edits-conflict-markers=true` test_env.jj_cmd_success(&repo_path, &["undo"]); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["diff"]), @""); std::fs::write( &editor_script, ["dump editor1", "write\nresolution\n"].join("\0"), ) .unwrap(); test_env.jj_cmd_success( &repo_path, &[ "resolve", "--config-toml", "merge-tools.fake-editor.merge-tool-edits-conflict-markers=true", ], ); insta::assert_snapshot!( std::fs::read_to_string(test_env.env_root().join("editor1")).unwrap(), @r###" <<<<<<< %%%%%%% -base +a +++++++ b >>>>>>> "###); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["diff"]), @r###" Resolved conflict in file: 1 1: <<<<<<>>>>>> "###); // Check that if merge tool leaves conflict markers in output file and // `merge-tool-edits-conflict-markers=true`, these markers are properly parsed. test_env.jj_cmd_success(&repo_path, &["undo"]); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["diff"]), @""); std::fs::write( &editor_script, [ "dump editor2", "write <<<<<<< %%%%%%% -some +fake +++++++ conflict >>>>>>> ", ] .join("\0"), ) .unwrap(); insta::assert_snapshot!( test_env.jj_cmd_success( &repo_path, &[ "resolve", "--config-toml", "merge-tools.fake-editor.merge-tool-edits-conflict-markers=true", ], ), @r###" Working copy now at: 0bb40c908c8b conflict Added 0 files, modified 1 files, removed 0 files After this operation, some files at this revision still have conflicts: file 2-sided conflict "###); insta::assert_snapshot!( std::fs::read_to_string(test_env.env_root().join("editor2")).unwrap(), @r###" <<<<<<< %%%%%%% -base +a +++++++ b >>>>>>> "###); // Note the "Modified" below insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["diff"]), @r###" Modified conflict in file: 1 1: <<<<<<< 2 2: %%%%%%% 3 3: -basesome 4 4: +afake 5 5: +++++++ 6 6: bconflict 7 7: >>>>>>> "###); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["resolve", "--list"]), @r###" file 2-sided conflict "###); // Check that if merge tool leaves conflict markers in output file but // `merge-tool-edits-conflict-markers=false` or is not specified, // `jj` considers the conflict resolved. test_env.jj_cmd_success(&repo_path, &["undo"]); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["diff"]), @""); std::fs::write( &editor_script, [ "dump editor3", "write <<<<<<< %%%%%%% -some +fake +++++++ conflict >>>>>>> ", ] .join("\0"), ) .unwrap(); insta::assert_snapshot!( test_env.jj_cmd_success(&repo_path, &["resolve"]), @r###" Working copy now at: 95418cb82ab1 conflict Added 0 files, modified 1 files, removed 0 files "###); insta::assert_snapshot!( std::fs::read_to_string(test_env.env_root().join("editor3")).unwrap(), @r###" "###); // Note the "Resolved" below insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["diff"]), @r###" Resolved conflict in file: 1 1: <<<<<<< 2 2: %%%%%%% 3 3: -basesome 4 4: +afake 5 5: +++++++ 6 6: bconflict 7 7: >>>>>>> "###); insta::assert_snapshot!(test_env.jj_cmd_cli_error(&repo_path, &["resolve", "--list"]), @r###" Error: No conflicts found at this revision "###); // TODO: Check that running `jj new` and then `jj resolve -r conflict` works // correctly. } fn check_resolve_produces_input_file( test_env: &mut TestEnvironment, repo_path: &Path, role: &str, expected_content: &str, ) { let editor_script = test_env.set_up_fake_editor(); std::fs::write(editor_script, format!("expect\n{expected_content}")).unwrap(); let merge_arg_config = format!(r#"merge-tools.fake-editor.merge-args = ["${role}"]"#); // This error means that fake-editor exited successfully but did not modify the // output file. // We cannot use `insta::assert_snapshot!` here after insta 1.22 due to // https://github.com/mitsuhiko/insta/commit/745b45b. Hopefully, this will again become possible // in the future. See also https://github.com/mitsuhiko/insta/issues/313. assert_eq!( &test_env.jj_cmd_failure(repo_path, &["resolve", "--config-toml", &merge_arg_config]), "Error: Failed to use external tool to resolve: The output file is either unchanged or \ empty after the editor quit (run with --verbose to see the exact invocation).\n" ); } #[test] fn test_normal_conflict_input_files() { let mut test_env = TestEnvironment::default(); test_env.jj_cmd_success(test_env.env_root(), &["init", "repo", "--git"]); let repo_path = test_env.env_root().join("repo"); create_commit(&test_env, &repo_path, "base", &[], &[("file", "base\n")]); create_commit(&test_env, &repo_path, "a", &["base"], &[("file", "a\n")]); create_commit(&test_env, &repo_path, "b", &["base"], &[("file", "b\n")]); create_commit(&test_env, &repo_path, "conflict", &["a", "b"], &[]); // Test the setup insta::assert_snapshot!(get_log_output(&test_env, &repo_path), @r###" @ conflict ├─╮ o │ b │ o a ├─╯ o base o "###); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["resolve", "--list"]), @r###" file 2-sided conflict "###); insta::assert_snapshot!( std::fs::read_to_string(repo_path.join("file")).unwrap() , @r###" <<<<<<< %%%%%%% -base +a +++++++ b >>>>>>> "###); check_resolve_produces_input_file(&mut test_env, &repo_path, "base", "base\n"); check_resolve_produces_input_file(&mut test_env, &repo_path, "left", "a\n"); check_resolve_produces_input_file(&mut test_env, &repo_path, "right", "b\n"); } #[test] fn test_baseless_conflict_input_files() { let mut test_env = TestEnvironment::default(); test_env.jj_cmd_success(test_env.env_root(), &["init", "repo", "--git"]); let repo_path = test_env.env_root().join("repo"); create_commit(&test_env, &repo_path, "base", &[], &[]); create_commit(&test_env, &repo_path, "a", &["base"], &[("file", "a\n")]); create_commit(&test_env, &repo_path, "b", &["base"], &[("file", "b\n")]); create_commit(&test_env, &repo_path, "conflict", &["a", "b"], &[]); // Test the setup insta::assert_snapshot!(get_log_output(&test_env, &repo_path), @r###" @ conflict ├─╮ o │ b │ o a ├─╯ o base o "###); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["resolve", "--list"]), @r###" file 2-sided conflict "###); insta::assert_snapshot!( std::fs::read_to_string(repo_path.join("file")).unwrap() , @r###" <<<<<<< %%%%%%% +a +++++++ b >>>>>>> "###); check_resolve_produces_input_file(&mut test_env, &repo_path, "base", ""); check_resolve_produces_input_file(&mut test_env, &repo_path, "left", "a\n"); check_resolve_produces_input_file(&mut test_env, &repo_path, "right", "b\n"); } #[test] fn test_too_many_parents() { let test_env = TestEnvironment::default(); test_env.jj_cmd_success(test_env.env_root(), &["init", "repo", "--git"]); let repo_path = test_env.env_root().join("repo"); create_commit(&test_env, &repo_path, "base", &[], &[("file", "base\n")]); create_commit(&test_env, &repo_path, "a", &["base"], &[("file", "a\n")]); create_commit(&test_env, &repo_path, "b", &["base"], &[("file", "b\n")]); create_commit(&test_env, &repo_path, "c", &["base"], &[("file", "c\n")]); create_commit(&test_env, &repo_path, "conflict", &["a", "b", "c"], &[]); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["resolve", "--list"]), @r###" file 3-sided conflict "###); // Test warning color insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["resolve", "--list", "--color=always"]), @r###" file 3-sided conflict "###); let error = test_env.jj_cmd_failure(&repo_path, &["resolve"]); insta::assert_snapshot!(error, @r###" Error: Failed to use external tool to resolve: The conflict at "file" has 2 removes and 3 adds. At most 1 remove and 2 adds are supported. "###); } #[test] fn test_edit_delete_conflict_input_files() { let mut test_env = TestEnvironment::default(); test_env.jj_cmd_success(test_env.env_root(), &["init", "repo", "--git"]); let repo_path = test_env.env_root().join("repo"); create_commit(&test_env, &repo_path, "base", &[], &[("file", "base\n")]); create_commit(&test_env, &repo_path, "a", &["base"], &[("file", "a\n")]); create_commit(&test_env, &repo_path, "b", &["base"], &[]); std::fs::remove_file(repo_path.join("file")).unwrap(); create_commit(&test_env, &repo_path, "conflict", &["a", "b"], &[]); // Test the setup insta::assert_snapshot!(get_log_output(&test_env, &repo_path), @r###" @ conflict ├─╮ o │ b │ o a ├─╯ o base o "###); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["resolve", "--list"]), @r###" file 2-sided conflict including 1 deletion "###); insta::assert_snapshot!( std::fs::read_to_string(repo_path.join("file")).unwrap() , @r###" <<<<<<< +++++++ a %%%%%%% -base >>>>>>> "###); check_resolve_produces_input_file(&mut test_env, &repo_path, "base", "base\n"); check_resolve_produces_input_file(&mut test_env, &repo_path, "left", "a\n"); check_resolve_produces_input_file(&mut test_env, &repo_path, "right", ""); } #[test] fn test_file_vs_dir() { let test_env = TestEnvironment::default(); test_env.jj_cmd_success(test_env.env_root(), &["init", "repo", "--git"]); let repo_path = test_env.env_root().join("repo"); create_commit(&test_env, &repo_path, "base", &[], &[("file", "base\n")]); create_commit(&test_env, &repo_path, "a", &["base"], &[("file", "a\n")]); create_commit(&test_env, &repo_path, "b", &["base"], &[]); std::fs::remove_file(repo_path.join("file")).unwrap(); std::fs::create_dir(repo_path.join("file")).unwrap(); // Without a placeholder file, `jj` ignores an empty directory std::fs::write(repo_path.join("file").join("placeholder"), "").unwrap(); create_commit(&test_env, &repo_path, "conflict", &["a", "b"], &[]); insta::assert_snapshot!(get_log_output(&test_env, &repo_path), @r###" @ conflict ├─╮ o │ b │ o a ├─╯ o base o "###); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["resolve", "--list"]), @r###" file 2-sided conflict including a directory "###); let error = test_env.jj_cmd_failure(&repo_path, &["resolve"]); insta::assert_snapshot!(error, @r###" Error: Failed to use external tool to resolve: Only conflicts that involve normal files (not symlinks, not executable, etc.) are supported. Conflict summary for "file": Conflict: Removing file with id df967b96a579e45a18b8251732d16804b2e56a55 Adding file with id 78981922613b2afb6025042ff6bd878ac1994e85 Adding tree with id 133bb38fc4e4bf6b551f1f04db7e48f04cac2877 "###); } #[test] fn test_description_with_dir_and_deletion() { let test_env = TestEnvironment::default(); test_env.jj_cmd_success(test_env.env_root(), &["init", "repo", "--git"]); let repo_path = test_env.env_root().join("repo"); create_commit(&test_env, &repo_path, "base", &[], &[("file", "base\n")]); create_commit(&test_env, &repo_path, "edit", &["base"], &[("file", "b\n")]); create_commit(&test_env, &repo_path, "dir", &["base"], &[]); std::fs::remove_file(repo_path.join("file")).unwrap(); std::fs::create_dir(repo_path.join("file")).unwrap(); // Without a placeholder file, `jj` ignores an empty directory std::fs::write(repo_path.join("file").join("placeholder"), "").unwrap(); create_commit(&test_env, &repo_path, "del", &["base"], &[]); std::fs::remove_file(repo_path.join("file")).unwrap(); create_commit( &test_env, &repo_path, "conflict", &["edit", "dir", "del"], &[], ); insta::assert_snapshot!(get_log_output(&test_env, &repo_path), @r###" @ conflict ├─┬─╮ o │ │ del │ o │ dir ├─╯ │ │ o edit ├───╯ o base o "###); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["resolve", "--list"]), @r###" file 3-sided conflict including 1 deletion and a directory "###); // Test warning color. The deletion is fine, so it's not highlighted insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["resolve", "--list", "--color=always"]), @r###" file 3-sided conflict including 1 deletion and a directory "###); let error = test_env.jj_cmd_failure(&repo_path, &["resolve"]); insta::assert_snapshot!(error, @r###" Error: Failed to use external tool to resolve: Only conflicts that involve normal files (not symlinks, not executable, etc.) are supported. Conflict summary for "file": Conflict: Removing file with id df967b96a579e45a18b8251732d16804b2e56a55 Removing file with id df967b96a579e45a18b8251732d16804b2e56a55 Adding file with id 61780798228d17af2d34fce4cfbdf35556832472 Adding tree with id 133bb38fc4e4bf6b551f1f04db7e48f04cac2877 "###); } #[test] fn test_multiple_conflicts() { let mut test_env = TestEnvironment::default(); test_env.jj_cmd_success(test_env.env_root(), &["init", "repo", "--git"]); let repo_path = test_env.env_root().join("repo"); create_commit( &test_env, &repo_path, "base", &[], &[ ( "this_file_has_a_very_long_name_to_test_padding", "first base\n", ), ("another_file", "second base\n"), ], ); create_commit( &test_env, &repo_path, "a", &["base"], &[ ( "this_file_has_a_very_long_name_to_test_padding", "first a\n", ), ("another_file", "second a\n"), ], ); create_commit( &test_env, &repo_path, "b", &["base"], &[ ( "this_file_has_a_very_long_name_to_test_padding", "first b\n", ), ("another_file", "second b\n"), ], ); create_commit(&test_env, &repo_path, "conflict", &["a", "b"], &[]); // Test the setup insta::assert_snapshot!(get_log_output(&test_env, &repo_path), @r###" @ conflict ├─╮ o │ b │ o a ├─╯ o base o "###); insta::assert_snapshot!( std::fs::read_to_string(repo_path.join("this_file_has_a_very_long_name_to_test_padding")).unwrap() , @r###" <<<<<<< %%%%%%% -first base +first a +++++++ first b >>>>>>> "###); insta::assert_snapshot!( std::fs::read_to_string(repo_path.join("another_file")).unwrap() , @r###" <<<<<<< %%%%%%% -second base +second a +++++++ second b >>>>>>> "###); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["resolve", "--list"]), @r###" another_file 2-sided conflict this_file_has_a_very_long_name_to_test_padding 2-sided conflict "###); // Test colors insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["resolve", "--list", "--color=always"]), @r###" another_file 2-sided conflict this_file_has_a_very_long_name_to_test_padding 2-sided conflict "###); let editor_script = test_env.set_up_fake_editor(); // Check that we can manually pick which of the conflicts to resolve first std::fs::write(&editor_script, "expect\n\0write\nresolution another_file\n").unwrap(); insta::assert_snapshot!( test_env.jj_cmd_success(&repo_path, &["resolve", "another_file"]), @r###" Working copy now at: 07feb084c0d2 conflict Added 0 files, modified 1 files, removed 0 files After this operation, some files at this revision still have conflicts: this_file_has_a_very_long_name_to_test_padding 2-sided conflict "###); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["diff"]), @r###" Resolved conflict in another_file: 1 : <<<<<<< 2 : %%%%%%% 3 1: -secondresolution baseanother_file 4 : +second a 5 : +++++++ 6 : second b 7 : >>>>>>> "###); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["resolve", "--list"]), @r###" this_file_has_a_very_long_name_to_test_padding 2-sided conflict "###); // Repeat the above with the `--quiet` option. test_env.jj_cmd_success(&repo_path, &["undo"]); std::fs::write(&editor_script, "expect\n\0write\nresolution another_file\n").unwrap(); insta::assert_snapshot!( test_env.jj_cmd_success(&repo_path, &["resolve", "--quiet", "another_file"]), @r###" Working copy now at: ff142405c921 conflict Added 0 files, modified 1 files, removed 0 files "###); // For the rest of the test, we call `jj resolve` several times in a row to // resolve each conflict in the order it chooses. test_env.jj_cmd_success(&repo_path, &["undo"]); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["diff"]), @""); std::fs::write( &editor_script, "expect\n\0write\nfirst resolution for auto-chosen file\n", ) .unwrap(); test_env.jj_cmd_success(&repo_path, &["resolve"]); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["diff"]), @r###" Resolved conflict in another_file: 1 : <<<<<<< 2 : %%%%%%% 3 1: first resolution for auto-secondchosen basefile 4 : +second a 5 : +++++++ 6 : second b 7 : >>>>>>> "###); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["resolve", "--list"]), @r###" this_file_has_a_very_long_name_to_test_padding 2-sided conflict "###); std::fs::write( &editor_script, "expect\n\0write\nsecond resolution for auto-chosen file\n", ) .unwrap(); test_env.jj_cmd_success(&repo_path, &["resolve"]); insta::assert_snapshot!(test_env.jj_cmd_success(&repo_path, &["diff"]), @r###" Resolved conflict in another_file: 1 : <<<<<<< 2 : %%%%%%% 3 1: first resolution for auto-secondchosen basefile 4 : +second a 5 : +++++++ 6 : second b 7 : >>>>>>> Resolved conflict in this_file_has_a_very_long_name_to_test_padding: 1 : <<<<<<< 2 : %%%%%%% 3 1: second resolution for auto-firstchosen basefile 4 : +first a 5 : +++++++ 6 : first b 7 : >>>>>>> "###); insta::assert_snapshot!(test_env.jj_cmd_cli_error(&repo_path, &["resolve", "--list"]), @r###" Error: No conflicts found at this revision "###); insta::assert_snapshot!(test_env.jj_cmd_cli_error(&repo_path, &["resolve"]), @r###" Error: No conflicts found at this revision "###); }