mirror of
https://github.com/martinvonz/jj.git
synced 2025-02-09 22:16:32 +00:00
enables symlink tests on windows, ignoring failures due to disabled developer mode, and updates windows.md
244 lines
7.7 KiB
Rust
244 lines
7.7 KiB
Rust
// Copyright 2021 The Jujutsu Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// https://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#![allow(missing_docs)]
|
|
|
|
use std::fs::{self, File};
|
|
use std::path::{Component, Path, PathBuf};
|
|
use std::{io, iter};
|
|
|
|
use tempfile::{NamedTempFile, PersistError};
|
|
use thiserror::Error;
|
|
|
|
pub use self::platform::*;
|
|
|
|
#[derive(Debug, Error)]
|
|
#[error("Cannot access {path}")]
|
|
pub struct PathError {
|
|
pub path: PathBuf,
|
|
#[source]
|
|
pub error: io::Error,
|
|
}
|
|
|
|
pub(crate) trait IoResultExt<T> {
|
|
fn context(self, path: impl AsRef<Path>) -> Result<T, PathError>;
|
|
}
|
|
|
|
impl<T> IoResultExt<T> for io::Result<T> {
|
|
fn context(self, path: impl AsRef<Path>) -> Result<T, PathError> {
|
|
self.map_err(|error| PathError {
|
|
path: path.as_ref().to_path_buf(),
|
|
error,
|
|
})
|
|
}
|
|
}
|
|
|
|
/// Creates a directory or does nothing if the directory already exists.
|
|
///
|
|
/// Returns the underlying error if the directory can't be created.
|
|
/// The function will also fail if intermediate directories on the path do not
|
|
/// already exist.
|
|
pub fn create_or_reuse_dir(dirname: &Path) -> io::Result<()> {
|
|
match fs::create_dir(dirname) {
|
|
Ok(()) => Ok(()),
|
|
Err(_) if dirname.is_dir() => Ok(()),
|
|
Err(e) => Err(e),
|
|
}
|
|
}
|
|
|
|
/// Removes all files in the directory, but not the directory itself.
|
|
///
|
|
/// The directory must exist, and there should be no sub directories.
|
|
pub fn remove_dir_contents(dirname: &Path) -> Result<(), PathError> {
|
|
for entry in dirname.read_dir().context(dirname)? {
|
|
let entry = entry.context(dirname)?;
|
|
let path = entry.path();
|
|
fs::remove_file(&path).context(&path)?;
|
|
}
|
|
Ok(())
|
|
}
|
|
|
|
/// Turns the given `to` path into relative path starting from the `from` path.
|
|
///
|
|
/// Both `from` and `to` paths are supposed to be absolute and normalized in the
|
|
/// same manner.
|
|
pub fn relative_path(from: &Path, to: &Path) -> PathBuf {
|
|
// Find common prefix.
|
|
for (i, base) in from.ancestors().enumerate() {
|
|
if let Ok(suffix) = to.strip_prefix(base) {
|
|
if i == 0 && suffix.as_os_str().is_empty() {
|
|
return ".".into();
|
|
} else {
|
|
let mut result = PathBuf::from_iter(iter::repeat("..").take(i));
|
|
result.push(suffix);
|
|
return result;
|
|
}
|
|
}
|
|
}
|
|
|
|
// No common prefix found. Return the original (absolute) path.
|
|
to.to_owned()
|
|
}
|
|
|
|
/// Consumes as much `..` and `.` as possible without considering symlinks.
|
|
pub fn normalize_path(path: &Path) -> PathBuf {
|
|
let mut result = PathBuf::new();
|
|
for c in path.components() {
|
|
match c {
|
|
Component::CurDir => {}
|
|
Component::ParentDir
|
|
if matches!(result.components().next_back(), Some(Component::Normal(_))) =>
|
|
{
|
|
// Do not pop ".."
|
|
let popped = result.pop();
|
|
assert!(popped);
|
|
}
|
|
_ => {
|
|
result.push(c);
|
|
}
|
|
}
|
|
}
|
|
|
|
if result.as_os_str().is_empty() {
|
|
".".into()
|
|
} else {
|
|
result
|
|
}
|
|
}
|
|
|
|
/// Like `NamedTempFile::persist()`, but doesn't try to overwrite the existing
|
|
/// target on Windows.
|
|
pub fn persist_content_addressed_temp_file<P: AsRef<Path>>(
|
|
temp_file: NamedTempFile,
|
|
new_path: P,
|
|
) -> io::Result<File> {
|
|
if cfg!(windows) {
|
|
// On Windows, overwriting file can fail if the file is opened without
|
|
// FILE_SHARE_DELETE for example. We don't need to take a risk if the
|
|
// file already exists.
|
|
match temp_file.persist_noclobber(&new_path) {
|
|
Ok(file) => Ok(file),
|
|
Err(PersistError { error, file: _ }) => {
|
|
if let Ok(existing_file) = File::open(new_path) {
|
|
// TODO: Update mtime to help GC keep this file
|
|
Ok(existing_file)
|
|
} else {
|
|
Err(error)
|
|
}
|
|
}
|
|
}
|
|
} else {
|
|
// On Unix, rename() is atomic and should succeed even if the
|
|
// destination file exists. Checking if the target exists might involve
|
|
// non-atomic operation, so don't use persist_noclobber().
|
|
temp_file
|
|
.persist(new_path)
|
|
.map_err(|PersistError { error, file: _ }| error)
|
|
}
|
|
}
|
|
|
|
#[cfg(unix)]
|
|
mod platform {
|
|
use std::io;
|
|
use std::os::unix::fs::symlink;
|
|
use std::path::Path;
|
|
|
|
/// Symlinks are always available on UNIX
|
|
pub fn check_symlink_support() -> io::Result<bool> {
|
|
Ok(true)
|
|
}
|
|
|
|
pub fn try_symlink<P: AsRef<Path>, Q: AsRef<Path>>(original: P, link: Q) -> io::Result<()> {
|
|
symlink(original, link)
|
|
}
|
|
}
|
|
|
|
#[cfg(windows)]
|
|
mod platform {
|
|
use std::io;
|
|
use std::os::windows::fs::symlink_file;
|
|
use std::path::Path;
|
|
|
|
use winreg::enums::HKEY_LOCAL_MACHINE;
|
|
use winreg::RegKey;
|
|
|
|
/// Symlinks may or may not be enabled on Windows. They require the
|
|
/// Developer Mode setting, which is stored in the registry key below.
|
|
pub fn check_symlink_support() -> io::Result<bool> {
|
|
let hklm = RegKey::predef(HKEY_LOCAL_MACHINE);
|
|
let sideloading =
|
|
hklm.open_subkey("SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\AppModelUnlock")?;
|
|
let developer_mode: u32 = sideloading.get_value("AllowDevelopmentWithoutDevLicense")?;
|
|
Ok(developer_mode == 1)
|
|
}
|
|
|
|
pub fn try_symlink<P: AsRef<Path>, Q: AsRef<Path>>(original: P, link: Q) -> io::Result<()> {
|
|
// this will create a nonfunctional link for directories, but at the moment
|
|
// we don't have enough information in the tree to determine whether the
|
|
// symlink target is a file or a directory
|
|
// note: if developer mode is not enabled the error code will be 1314,
|
|
// ERROR_PRIVILEGE_NOT_HELD
|
|
|
|
symlink_file(original, link)
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use std::io::Write;
|
|
|
|
use test_case::test_case;
|
|
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn normalize_too_many_dot_dot() {
|
|
assert_eq!(normalize_path(Path::new("foo/..")), Path::new("."));
|
|
assert_eq!(normalize_path(Path::new("foo/../..")), Path::new(".."));
|
|
assert_eq!(
|
|
normalize_path(Path::new("foo/../../..")),
|
|
Path::new("../..")
|
|
);
|
|
assert_eq!(
|
|
normalize_path(Path::new("foo/../../../bar/baz/..")),
|
|
Path::new("../../bar")
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn test_persist_no_existing_file() {
|
|
let temp_dir = testutils::new_temp_dir();
|
|
let target = temp_dir.path().join("file");
|
|
let mut temp_file = NamedTempFile::new_in(&temp_dir).unwrap();
|
|
temp_file.write_all(b"contents").unwrap();
|
|
assert!(persist_content_addressed_temp_file(temp_file, target).is_ok());
|
|
}
|
|
|
|
#[test_case(false ; "existing file open")]
|
|
#[test_case(true ; "existing file closed")]
|
|
fn test_persist_target_exists(existing_file_closed: bool) {
|
|
let temp_dir = testutils::new_temp_dir();
|
|
let target = temp_dir.path().join("file");
|
|
let mut temp_file = NamedTempFile::new_in(&temp_dir).unwrap();
|
|
temp_file.write_all(b"contents").unwrap();
|
|
|
|
let mut file = File::create(&target).unwrap();
|
|
file.write_all(b"contents").unwrap();
|
|
if existing_file_closed {
|
|
drop(file);
|
|
}
|
|
|
|
assert!(persist_content_addressed_temp_file(temp_file, &target).is_ok());
|
|
}
|
|
}
|