mirrors/lldap
1
0
Fork 0
mirror of https://github.com/lldap/lldap.git synced 2024-11-24 08:45:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

server: Add logging for password resets, add name for successful opaque logins
Some checks failed
Rust / pre_job (push) Has been cancelled
Details
Rust / cargo test (push) Has been cancelled
Details
Rust / cargo clippy (push) Has been cancelled
Details
Rust / cargo fmt (push) Has been cancelled
Details
Rust / Code coverage (push) Has been cancelled
Details

Browse source
This commit is contained in:
Valentin Tolmer 2024-09-26 22:31:57 +02:00 committed by nitnelave
parent 0c6a92a8fa
commit 1f3f73585b
2 changed files with 16 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
server/src/domain/sql_opaque_handler.rs
View file

@ -9,10 +9,9 @@ use super::{
use async_trait::async_trait;
use base64::Engine;
use lldap_auth::opaque;
use log::info;
use sea_orm::{ActiveModelTrait, ActiveValue, EntityTrait, QuerySelect};
use secstr::SecUtf8;
use tracing::{debug, instrument};
use tracing::{debug, info, instrument, warn};
type SqlOpaqueHandler = SqlBackendHandler;
@ -103,6 +102,7 @@ impl OpaqueHandler for SqlOpaqueHandler {
request: login::ClientLoginStartRequest,
) -> Result<login::ServerLoginStartResponse> {
let user_id = request.username;
info!(r#"OPAQUE login attempt for "{}""#, &user_id);
let maybe_password_file = self
.get_password_file_for_user(user_id.clone())
.await?
@ -147,9 +147,16 @@ impl OpaqueHandler for SqlOpaqueHandler {
)?)?;
// Finish the login: this makes sure the client data is correct, and gives a session key we
// don't need.
let _session_key =
opaque::server::login::finish_login(server_login, request.credential_finalization)?
.session_key;
match opaque::server::login::finish_login(server_login, request.credential_finalization) {
Ok(session) => {
info!(r#"OPAQUE login successful for "{}""#, &username);
let _ = session.session_key;
}
Err(e) => {
warn!(r#"OPAQUE login attempt failed for "{}""#, &username);
return Err(e.into());
}
};
Ok(username)
}
@ -191,11 +198,12 @@ impl OpaqueHandler for SqlOpaqueHandler {
opaque::server::registration::get_password_file(request.registration_upload);
// Set the user password to the new password.
let user_update = model::users::ActiveModel {
user_id: ActiveValue::Set(username),
user_id: ActiveValue::Set(username.clone()),
password_hash: ActiveValue::Set(Some(password_file.serialize())),
..Default::default()
};
user_update.update(&self.sql_pool).await?;
info!(r#"Successfully (re)set password for "{}""#, &username);
Ok(())
}
}

11
server/src/infra/auth_service.rs
View file

@ -345,7 +345,6 @@ async fn opaque_login_start<Backend>(
where
Backend: OpaqueHandler + 'static,
{
info!(r#"OPAQUE login attempt for "{}""#, &request.username);
data.get_opaque_handler()
.login_start(request.into_inner())
.await
@ -407,14 +406,8 @@ where
.login_finish(request.into_inner())
.await
{
Ok(name) => {
info!(r#"OPAQUE login successful"#);
get_login_successful_response(&data, &name).await
}
Err(e) => {
warn!(r#"OPAQUE login attempt failed"#);
Err(e.into())
}
Ok(name) => get_login_successful_response(&data, &name).await,
Err(e) => Err(e.into()),
}
}