chore: remove redundant todo

This commit is contained in:
Zixuan Chen 2022-11-08 10:50:55 +08:00
parent 9050f6dd3f
commit e833c1d5d7
3 changed files with 2 additions and 15 deletions

View file

@ -86,17 +86,6 @@ pub(crate) trait DagUtils: Dag {
}
impl<T: Dag + ?Sized> DagUtils for T {
//
// TODO: Maybe use Result return type
// TODO: Maybe we only need one heap?
// TODO: benchmark
// how to test better?
// - converge through other nodes
//
/// only returns a single root.
/// but the least common ancestor may be more than one root.
/// But that is a rare case.
///
#[inline]
fn find_common_ancestor(&self, a_id: &[ID], b_id: &[ID]) -> SmallVec<[ID; 2]> {
find_common_ancestor(&|id| self.get(id), a_id, b_id)

View file

@ -49,7 +49,7 @@ pub struct DagIterator<'a, T> {
visited: VersionVector,
}
// TODO: Need benchmark on memory
/// Should only use it on debug, because it's slow and likely to use lots of mem
impl<'a, T: DagNode> Iterator for DagIterator<'a, T> {
type Item = &'a T;
@ -103,7 +103,7 @@ pub(crate) struct DagIteratorVV<'a, T> {
heap: BinaryHeap<IdHeapItem>,
}
// TODO: Need benchmark on memory
/// Should only use it on debug, because it's slow and likely to use lots of mem
impl<'a, T: DagNode> Iterator for DagIteratorVV<'a, T> {
type Item = (&'a T, VersionVector);

View file

@ -35,8 +35,6 @@ pub struct InternalNode<'a, T: Rle + 'a, A: RleTreeTrait<T> + 'a> {
}
// TODO: remove bump field
// TODO: remove parent field?
// TODO: only one child?
pub struct LeafNode<'a, T: Rle + 'a, A: RleTreeTrait<T>> {
bump: &'a A::Arena,
pub(crate) parent: NonNull<InternalNode<'a, T, A>>,