mirrors/loro
1
0
Fork 0
mirror of https://github.com/loro-dev/loro.git synced 2025-02-02 11:06:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore: add todo doc

Browse source
This commit is contained in:
Zixuan Chen 2022-10-11 11:45:17 +08:00
parent 374e32384e
commit ee5c9bb990
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
crates/rle/src/rle_tree/node/internal_impl.rs
View file

@ -110,6 +110,7 @@ impl<'a, T: Rle, A: RleTreeTrait<T>> InternalNode<'a, T, A> {
let (direct_delete_end, to_del_end_offset) = let (direct_delete_end, to_del_end_offset) =
to.map_or((self.children.len(), None), |x| self._delete_end(x)); to.map_or((self.children.len(), None), |x| self._delete_end(x));
let deleted_len = direct_delete_end as isize - direct_delete_start as isize; let deleted_len = direct_delete_end as isize - direct_delete_start as isize;
// TODO: maybe we can simplify this insertions logic
let mut insertions = vec![]; let mut insertions = vec![];
{ {
// handle removing at the end point // handle removing at the end point
@ -153,11 +154,13 @@ impl<'a, T: Rle, A: RleTreeTrait<T>> InternalNode<'a, T, A> {
if let Err(new) = if let Err(new) =
node._delete(Some(del_from), None, visited, depth + 1, notify) node._delete(Some(del_from), None, visited, depth + 1, notify)
{ {
// TODO: maybe even if we panic here it can still work
insertions.push((direct_delete_start, new)); insertions.push((direct_delete_start, new));
} }
} }
Node::Leaf(node) => { Node::Leaf(node) => {
if let Err(new) = node.delete(Some(del_from), None, notify) { if let Err(new) = node.delete(Some(del_from), None, notify) {
// TODO: maybe even if we panic here it can still work
insertions.push((direct_delete_start, new)); insertions.push((direct_delete_start, new));
} }
} }
@ -173,11 +176,13 @@ impl<'a, T: Rle, A: RleTreeTrait<T>> InternalNode<'a, T, A> {
if let Err(new) = if let Err(new) =
node._delete(None, Some(del_to), visited, depth + 1, notify) node._delete(None, Some(del_to), visited, depth + 1, notify)
{ {
// TODO: maybe even if we panic here it can still work
insertions.push((direct_delete_end + 1, new)); insertions.push((direct_delete_end + 1, new));
} }
} }
Node::Leaf(node) => { Node::Leaf(node) => {
if let Err(new) = node.delete(None, Some(del_to), notify) { if let Err(new) = node.delete(None, Some(del_to), notify) {
// TODO: maybe even if we panic here it can still work
insertions.push((direct_delete_end + 1, new)); insertions.push((direct_delete_end + 1, new));
} }
} }