mirrors/make
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/make.git synced 2024-11-24 12:19:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Prefer memcpy to strncpy if either will do

Browse source 
strncpy is trickier and a bit slower.
* src/function.c (func_realpath, func_abspath):
* src/misc.c (xstrndup):
Prefer memcpy or mempcpy to strncpy when the source length is known.
This commit is contained in:
Paul Eggert 2024-08-05 01:21:09 -07:00 committed by Paul Smith
parent 4d3bf7838f
commit c23a7e6232
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/function.c
View file

@ -2109,7 +2109,7 @@ abspath (const char *name, char *apath)
apath[3] = '/';
dest++;
root_len++;
/* strncpy above copied one character too many. */
/* memcpy above copied one character too many. */
name--;
}
else
@ -2178,13 +2178,13 @@ func_realpath (char *o, char **argv, const char *funcname UNUSED)
{
if (len < GET_PATH_MAX)
{
char *rp;
char *rp, *inend;
struct stat st;
PATH_VAR (in);
PATH_VAR (out);
strncpy (in, path, len);
in[len] = '\0';
inend = mempcpy (in, path, len);
*inend = '\0';
#ifdef HAVE_REALPATH
ENULLLOOP (rp, realpath (in, out));
@ -2353,9 +2353,9 @@ func_abspath (char *o, char **argv, const char *funcname UNUSED)
{
PATH_VAR (in);
PATH_VAR (out);
char *inend = mempcpy (in, path, len);
strncpy (in, path, len);
in[len] = '\0';
*inend = '\0';
if (abspath (in, out))
{

2
src/misc.c
View file

@ -351,7 +351,7 @@ xstrndup (const char *str, size_t length)
#else
result = xmalloc (length + 1);
if (length > 0)
strncpy (result, str, length);
memcpy (result, str, length);
result[length] = '\0';
#endif