salsa/src/memoized.rs

283 lines
8.5 KiB
Rust
Raw Normal View History

use crate::runtime::QueryDescriptorSet;
use crate::runtime::Revision;
use crate::runtime::StampedValue;
2018-09-28 15:04:52 +00:00
use crate::CycleDetected;
use crate::Query;
use crate::QueryContext;
use crate::QueryDescriptor;
2018-09-28 15:04:52 +00:00
use crate::QueryStorageOps;
use crate::QueryTable;
use log::debug;
use parking_lot::{RwLock, RwLockUpgradableReadGuard};
2018-09-28 15:04:52 +00:00
use rustc_hash::FxHashMap;
use std::any::Any;
use std::cell::RefCell;
use std::collections::hash_map::Entry;
use std::fmt::Debug;
use std::fmt::Display;
use std::fmt::Write;
use std::hash::Hash;
/// Memoized queries store the result plus a list of the other queries
/// that they invoked. This means we can avoid recomputing them when
/// none of those inputs have changed.
2018-09-28 15:26:53 +00:00
pub struct MemoizedStorage<QC, Q>
2018-09-28 15:04:52 +00:00
where
Q: Query<QC>,
QC: QueryContext,
2018-09-28 15:04:52 +00:00
{
map: RwLock<FxHashMap<Q::Key, QueryState<QC, Q>>>,
2018-09-28 15:04:52 +00:00
}
/// Defines the "current state" of query's memoized results.
enum QueryState<QC, Q>
where
Q: Query<QC>,
QC: QueryContext,
{
/// We are currently computing the result of this query; if we see
/// this value in the table, it indeeds a cycle.
InProgress,
/// We have computed the query already, and here is the result.
Memoized(Memo<QC, Q>),
2018-09-29 11:24:53 +00:00
}
struct Memo<QC, Q>
where
Q: Query<QC>,
QC: QueryContext,
{
value: Q::Value,
inputs: QueryDescriptorSet<QC>,
/// Last time that we checked our inputs to see if they have
/// changed. If this is equal to the current revision, then the
/// value is up to date. If not, we need to check our inputs and
/// see if any of them have changed since our last check -- if so,
/// we'll need to re-execute.
verified_at: Revision,
/// Last time that our value changed.
changed_at: Revision,
}
impl<QC, Q> Memo<QC, Q>
where
Q: Query<QC>,
QC: QueryContext,
{
fn stamped_value(&self) -> StampedValue<Q::Value> {
StampedValue {
value: self.value.clone(),
changed_at: self.changed_at,
}
}
}
2018-09-28 15:40:20 +00:00
impl<QC, Q> Default for MemoizedStorage<QC, Q>
where
Q: Query<QC>,
QC: QueryContext,
2018-09-28 15:40:20 +00:00
{
fn default() -> Self {
MemoizedStorage {
map: RwLock::new(FxHashMap::default()),
2018-09-28 15:40:20 +00:00
}
}
}
impl<QC, Q> MemoizedStorage<QC, Q>
2018-09-28 15:04:52 +00:00
where
Q: Query<QC>,
QC: QueryContext,
2018-09-28 15:04:52 +00:00
{
2018-09-30 14:22:11 +00:00
fn read(
2018-09-28 15:04:52 +00:00
&self,
2018-09-30 14:22:11 +00:00
query: &QC,
2018-09-28 15:04:52 +00:00
key: &Q::Key,
descriptor: &QC::QueryDescriptor,
) -> Result<StampedValue<Q::Value>, CycleDetected> {
let revision_now = query.salsa_runtime().current_revision();
debug!(
"{:?}({:?}): invoked at {:?}",
Q::default(),
key,
revision_now,
);
let mut old_value = {
let map_read = self.map.upgradable_read();
if let Some(value) = map_read.get(key) {
match value {
QueryState::InProgress => return Err(CycleDetected),
QueryState::Memoized(m) => {
debug!(
"{:?}({:?}): found memoized value verified_at={:?}",
Q::default(),
key,
m.verified_at,
);
if m.verified_at == revision_now {
debug!(
"{:?}({:?}): returning memoized value (changed_at={:?})",
Q::default(),
key,
m.changed_at,
);
return Ok(m.stamped_value());
}
}
}
2018-09-28 15:04:52 +00:00
}
let mut map_write = RwLockUpgradableReadGuard::upgrade(map_read);
map_write.insert(key.clone(), QueryState::InProgress)
};
// If we have an old-value, it *may* now be stale, since there
// has been a new revision since the last time we checked. So,
// first things first, let's walk over each of our previous
// inputs and check whether they are out of date.
if let Some(QueryState::Memoized(old_memo)) = &mut old_value {
if old_memo
.inputs
.iter()
.all(|old_input| !old_input.maybe_changed_since(query, old_memo.verified_at))
{
debug!("{:?}({:?}): inputs still valid", Q::default(), key);
// If none of out inputs have changed since the last time we refreshed
// our value, then our value must still be good. We'll just patch
// the verified-at date and re-use it.
old_memo.verified_at = revision_now;
let stamped_value = old_memo.stamped_value();
let mut map_write = self.map.write();
let placeholder = map_write.insert(key.clone(), old_value.unwrap());
assert!(
match placeholder {
Some(QueryState::InProgress) => true,
_ => false,
},
"expected in-progress state",
);
return Ok(stamped_value);
}
2018-09-28 15:04:52 +00:00
}
// Query was not previously executed or value is potentially
// stale. Let's execute!
let (value, inputs) = query
.salsa_runtime()
.execute_query_implementation::<Q>(query, descriptor, key);
2018-09-28 15:04:52 +00:00
// We assume that query is side-effect free -- that is, does
// not mutate the "inputs" to the query system. Sanity check
// that assumption here, at least to the best of our ability.
assert_eq!(
query.salsa_runtime().current_revision(),
revision_now,
"revision altered during query execution",
);
// If the new value is equal to the old one, then it didn't
// really change, even if some of its inputs have. So we can
// "backdate" our `changed_at` revision to be the same as the
// old value.
let mut changed_at = revision_now;
if let Some(QueryState::Memoized(old_memo)) = &old_value {
if old_memo.value == value {
changed_at = old_memo.changed_at;
}
}
2018-09-28 15:04:52 +00:00
{
let mut map_write = self.map.write();
2018-09-29 11:24:53 +00:00
let old_value = map_write.insert(
key.clone(),
QueryState::Memoized(Memo {
2018-09-29 11:24:53 +00:00
value: value.clone(),
inputs,
verified_at: revision_now,
changed_at,
2018-09-29 11:24:53 +00:00
}),
);
2018-09-28 15:04:52 +00:00
assert!(
match old_value {
Some(QueryState::InProgress) => true,
_ => false,
},
"expected in-progress state",
2018-09-28 15:04:52 +00:00
);
}
Ok(StampedValue { value, changed_at })
}
}
impl<QC, Q> QueryStorageOps<QC, Q> for MemoizedStorage<QC, Q>
where
Q: Query<QC>,
QC: QueryContext,
{
fn try_fetch<'q>(
&self,
query: &'q QC,
key: &Q::Key,
descriptor: &QC::QueryDescriptor,
) -> Result<Q::Value, CycleDetected> {
let StampedValue {
value,
changed_at: _,
} = self.read(query, key, &descriptor)?;
query.salsa_runtime().report_query_read(descriptor);
Ok(value)
}
fn maybe_changed_since(
&self,
query: &'q QC,
revision: Revision,
key: &Q::Key,
descriptor: &QC::QueryDescriptor,
) -> bool {
let revision_now = query.salsa_runtime().current_revision();
debug!(
"{:?}({:?})::maybe_changed_since(revision={:?}, revision_now={:?})",
Q::default(),
key,
revision,
revision_now,
);
// Check for the case where we have no cache entry, or our cache
// entry is up to date (common case):
{
let map_read = self.map.read();
match map_read.get(key) {
None | Some(QueryState::InProgress) => return true,
Some(QueryState::Memoized(memo)) => {
if memo.verified_at >= revision_now {
return memo.changed_at > revision;
}
}
}
}
// Otherwise fall back to the full read to compute the result.
match self.read(query, key, descriptor) {
Ok(v) => v.changed_at > revision,
Err(CycleDetected) => true,
}
2018-09-28 15:04:52 +00:00
}
}