From fc0a82bd10abdbcc5635309db85dc5776bd5f5b3 Mon Sep 17 00:00:00 2001 From: Micha Reiser Date: Thu, 25 Jul 2024 12:56:46 +0200 Subject: [PATCH] Add benchmark for query with many tracked structs --- Cargo.toml | 8 ++++++- benches/incremental.rs | 54 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 61 insertions(+), 1 deletion(-) create mode 100644 benches/incremental.rs diff --git a/Cargo.toml b/Cargo.toml index 09e1f3d3..c6a369cf 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -24,6 +24,7 @@ smallvec = "1.0.0" [dev-dependencies] annotate-snippets = "0.11.4" +criterion = "0.5.1" derive-new = "0.5.9" expect-test = "1.4.0" eyre = "0.6.8" @@ -33,5 +34,10 @@ rustversion = "1.0" test-log = "0.2.11" trybuild = "1.0" + +[[bench]] +name = "incremental" +harness = false + [workspace] -members = [ "components/salsa-macro-rules","components/salsa-macros"] +members = ["components/salsa-macro-rules", "components/salsa-macros"] diff --git a/benches/incremental.rs b/benches/incremental.rs new file mode 100644 index 00000000..a73efea2 --- /dev/null +++ b/benches/incremental.rs @@ -0,0 +1,54 @@ +use criterion::{criterion_group, criterion_main, BatchSize, Criterion}; +use salsa::Setter; + +#[salsa::input] +struct Input { + field: usize, +} + +#[salsa::tracked] +struct Tracked<'db> { + number: usize, +} + +#[salsa::tracked(return_ref)] +fn index<'db>(db: &'db dyn salsa::Database, input: Input) -> Vec> { + (0..input.field(db)).map(|i| Tracked::new(db, i)).collect() +} + +#[salsa::tracked] +fn root(db: &dyn salsa::Database, input: Input) -> usize { + let index = index(db, input); + index.len() +} + +fn many_tracked_structs(criterion: &mut Criterion) { + criterion.bench_function("many_tracked_structs", |b| { + b.iter_batched_ref( + || { + let db = salsa::default_database(); + + let input = Input::new(&db, 1_000); + let input2 = Input::new(&db, 1); + + // prewarm cache + let _ = root(&db, input); + let _ = root(&db, input2); + + (db, input, input2) + }, + |(db, input, input2)| { + // Make a change, but fetch the result for the other input + input2.set_field(db).to(2); + + let result = root(db, *input); + + assert_eq!(result, 1_000); + }, + BatchSize::LargeInput, + ); + }); +} + +criterion_group!(benches, many_tracked_structs); +criterion_main!(benches);