From d689d02117670c5ea57e642b3bb83191841f5bb1 Mon Sep 17 00:00:00 2001 From: Niko Matsakis Date: Thu, 1 Nov 2018 05:03:09 -0400 Subject: [PATCH] remove outdated note on atomicity; not a concern anymore --- src/lib.rs | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/lib.rs b/src/lib.rs index 83b2f1ca..be457896 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -44,17 +44,6 @@ pub trait Database: plumbing::DatabaseStorageTypes + plumbing::DatabaseOps { /// consume are marked as used. You then invoke this method to /// remove other values that were not needed for your main query /// results. - /// - /// **A note on atomicity.** Since `sweep_all` removes data that - /// hasn't been actively used since the last revision, executing - /// `sweep_all` concurrently with `set` operations is not - /// recommended. It won't do any *harm* -- but it may cause more - /// data to be discarded then you expect, leading to more - /// re-computation. You can use the [`lock_revision`][] method to - /// guarantee atomicity (or execute `sweep_all` from the same - /// threads that would be performing a `set`). - /// - /// [`lock_revision`]: struct.Runtime.html#method.lock_revision fn sweep_all(&self, strategy: SweepStrategy) { self.salsa_runtime().sweep_all(self, strategy); }