Niko Matsakis
b005820494
add a derive for DebugWithDb
2024-05-24 07:16:50 -04:00
Niko Matsakis
d98485d3cb
add a derive for salsa::Update
...
And a test for it. This is required if you
want to have structures in your tracked structs.
Looks we need one for salsa::DebugWithDb, too.
2024-05-24 07:16:50 -04:00
Niko Matsakis
b4b49fbd1b
split the Id conversion traits
...
We now have AsId (always present)
and FromId/LookupId (sometimes present).
AsId is no longer part of the
salsa public interface.
Replace the ad-hoc `salsa_id` etc methods with
calls to `AsId::as_id`.
2024-05-24 07:16:50 -04:00
Niko Matsakis
7519c3e2a6
extend IdentityInterner to be based on LookupId
2024-05-24 07:16:50 -04:00
Niko Matsakis
ab70786536
introduce LookupId trait
...
We are going to need it for tracked functions.
2024-05-24 07:16:50 -04:00
Niko Matsakis
cf2fa671f5
introduce IdLookup trait
...
We are going to need it for tracked functions.
2024-05-24 07:16:50 -04:00
Niko Matsakis
8d0f8fccbf
remove unnecessary uses of AsId
2024-05-24 07:16:50 -04:00
Niko Matsakis
d361e8adfb
add a 'db argument to SalsaStruct
2024-05-24 07:16:50 -04:00
Niko Matsakis
9607638d5d
permit interned structs with lifetimes
2024-05-24 07:16:50 -04:00
Niko Matsakis
0b8c27bc30
rename from TrackedStruct to just Struct
...
this will let us use different packages
but the same struct name from salsa struct
2024-05-24 07:16:50 -04:00
Niko Matsakis
5095d79d13
return a pointer from interning, not just id
2024-05-24 07:16:50 -04:00
Niko Matsakis
d6d522662c
have tracked struct intern its own keys
...
Previously tracked structs relied on an
interned ingredient to intern their keys.
But really it has more complex logic than we
need. Simpler to just remove it and duplicate
the basic concept.
2024-05-24 07:16:50 -04:00
Niko Matsakis
4822013523
permit interned data to take 'db lifetime
2024-05-24 07:16:50 -04:00
Niko Matsakis
97fc6a0920
rework interning to have a Configuration
...
This will permit GATs so that interned values
can carry lifetimes.
2024-05-24 07:16:50 -04:00
Niko Matsakis
fe4ff9816a
support db lifetimes in fields
2024-05-24 07:16:50 -04:00
Niko Matsakis
a84777d5a7
permit <'db> on tracked struct
...
tracked structs with `'db` carry a pointer
and not an id.
2024-05-24 07:16:50 -04:00
Niko Matsakis
e95c8b21fb
give fields a lifetime
2024-05-24 07:16:50 -04:00
Niko Matsakis
44a8a2f41c
make fn input/value a GAT
2024-05-24 07:16:50 -04:00
Niko Matsakis
b050bd874a
remove Key from Fn configuration
...
Just use salsa::Id for the most part.
2024-05-24 07:16:50 -04:00
Niko Matsakis
6e2647fa50
just take salsa::Id instead of id structs
2024-05-24 07:16:50 -04:00
Niko Matsakis
cb1a2bb75b
Revert "WIP permit 'db on tracked struct definitions (opt)"
...
This reverts commit 43b1b8ef3f98213279b9d0768847603299162f1f.
2024-05-24 07:16:50 -04:00
Niko Matsakis
b6311d8102
WIP permit 'db on tracked struct definitions (opt)
2024-05-24 07:16:50 -04:00
Niko Matsakis
5ce5e3c374
track and assert struct ingredient indices
...
We need a cheap way to compute field indices.
2024-05-24 07:16:50 -04:00
Niko Matsakis
ea1d452143
create a struct_map that encapsulates access
...
The internal API is now based around providing
references to the `TrackedStructValue`.
Documenting the invariants led to one interesting
case, which is that we sometimes verify a tracked
struct as not having changed (and even create
`&`-ref to it!) but then re-execute the function
around it.
We now guarantee that, in this case, the data
does not change, even if it has leaked values.
This is required to ensure soundness.
Add a test case about it.
2024-05-24 07:16:47 -04:00
Niko Matsakis
20cb307301
give trait more info about lifetime relationships
...
In particular, the ingredient and the database
have the same lifetime.
This will be useful later for safety conditions.
2024-05-24 07:15:40 -04:00
Niko Matsakis
a32078153b
separate marking the outputs as verified
...
There are 3 call-sites to this function:
* One of them has already marked the outputs
* One of them has no outputs
* The third does need to mark the outputs
2024-05-24 07:15:40 -04:00
Niko Matsakis
e24ace24eb
return &TrackedStructValue<C> from new_struct
...
This is a step towards the goal of keep a pointer
in the structs themselves.
2024-05-24 07:15:40 -04:00
Niko Matsakis
4533cd9e4b
adopt the Salsa 3.0 Update` trait
...
Right now, this doesn't change much except the
behavior in the event that `Eq` is not properly
implemented. In the future, it will enable
the use of references and slices and things.
2024-05-24 07:15:40 -04:00
Niko Matsakis
90597b18ab
remove stray eprintln
2024-04-12 04:57:41 -04:00
Niko Matsakis
f4a8ed650f
update tracked struct created_at when validated
...
Fixes #484
2024-04-05 05:15:59 -04:00
Niko Matsakis
9dfa84b693
improve doc comments
2024-04-03 06:30:31 -04:00
Niko Matsakis
389aa66bcf
print all fields in debug() but ignore deps
...
In a previous PR we added the `include_all_fields`
parameter to `DebugWithDb` to allow it to
not create spurious dependencies.
This PR takes a different approach: we simply
ignore the dependencies created during debug
operations. This is risky as it can create
incorrect dependencies, but it is way more
convenient and seems like what users probably
want.
It also means that `DebugWithDb` has a simpler
signature that matches the `Debug` trait again,
which seems good to me.
2024-04-03 05:59:11 -04:00
Niko Matsakis
b5aa4294bd
Merge pull request #481 from nikomatsakis/struct-field-ingredients
...
Struct field ingredients
2024-04-02 22:06:51 +00:00
Niko Matsakis
6eb9cb0d1b
complete comment
2024-04-02 06:52:38 -04:00
Niko Matsakis
e81b22315b
driveby: fix use of indexmap remove
...
We do care about the order of things in this
set, in general, so use `shift_remove`.
2024-04-02 06:30:53 -04:00
Niko Matsakis
39321ed920
fix clippy warnings
2024-04-02 06:29:44 -04:00
Niko Matsakis
9deaf3e149
Update components/salsa-2022/src/storage.rs
2024-04-02 06:15:43 -04:00
Niko Matsakis
54b33c335a
create tracked field-ingredients
2024-04-02 06:08:55 -04:00
Niko Matsakis
796dc004f2
remove "id" fields from interned table
...
First step towards the new tracked struct design.
SUBTLE: This is actually broken if the `#[id]`
fields have a broken hash. We'll fix that in the
next commit and add a test.
2024-04-02 06:08:33 -04:00
Mona Lisa
998bcf606a
chore: fmt
2024-03-15 23:01:30 +08:00
Mona Lisa
864344addb
fix: wrong condvar usage
2024-03-15 22:44:09 +08:00
Niko Matsakis
0543972429
extract transmute_lifetime into plumbing module
2024-03-14 05:44:15 -04:00
Niko Matsakis
4142ebca97
remove unnecessary Option
2024-03-13 05:37:53 -04:00
Niko Matsakis
e909ca5c97
add a comment clarifying
2024-03-12 06:30:54 -04:00
DropDemBits
407d6bcaa7
Bump arc-swap to 1.6.0
...
1.6.0 fixes some UB in previous versions of `arc-swap`.
2023-11-11 00:42:47 -05:00
Niko Matsakis
f1d318a279
Merge pull request #450 from DropDemBits/placement-new-jars
...
Initialize jars in-place
2023-11-09 10:25:26 +00:00
Niko Matsakis
703794b1c7
Merge pull request #461 from Y-Nak/provide-access-to-ingredient-index
...
Provide a public API to obtain `IngredientIndex`
2023-11-09 10:21:37 +00:00
Niko Matsakis
6ac3724e0a
Merge pull request #449 from DropDemBits/assert-on-tracked-struct-outside-of-tracked-fn
...
Improve assert message when creating a tracked struct outside of a tracked function
2023-10-28 06:58:14 -04:00
Yoshitomo Nakanishi
59f094f512
Provide public API to get IngredientIndex
2023-10-08 20:40:52 +02:00
Josh Stone
db3ef9a2ba
Upgrade to indexmap 2
2023-09-29 17:11:34 -07:00
