mirror of
https://github.com/salsa-rs/salsa.git
synced 2025-01-23 13:10:19 +00:00
9df075b63c
Accumulators don't currently work across revisions due to a few bugs. This commit adds 2 tests to show the problems and reworks the implementation strategy. We keep track of when the values in an accumulator were pushed and reset the vector to empty when the push occurs in a new revision. We also ignore stale values from old revisions (but update the revision when it is marked as validated). Finally, we treat an accumulator as an untracked read, which is quite conservative but correct. To get better reuse, we would need to (a) somehow determine when different values were pushed, e.g. by hashing or tracked the old values; and (b) have some `DatabaseKeyIndex` we can use to identify "the values pushed by this query". Both of these would add overhead to accumulators and I didn'τ feel like doing it, particularly since the main use case for them is communicating errors and things which are not typically used from within queries. |
||
|---|---|---|
| .. | ||
| parallel | ||
| accumulate-from-tracked-fn.rs | ||
| accumulate-reuse.rs | ||
| accumulate.rs | ||
| cycles.rs | ||
| deletion-cascade.rs | ||
| deletion.rs | ||
| expect_reuse_field_x_of_a_tracked_struct_changes_but_fn_deponds_on_field_y.rs | ||
| expect_reuse_field_x_of_an_input_changes_but_fn_deponds_on_field_y.rs | ||
| hello_world.rs | ||
| mutate_in_place.rs | ||
| specify_tracked_fn_in_rev_1_but_not_2.rs | ||
| tracked_fn_on_input.rs | ||
| tracked_fn_on_tracked.rs | ||
| tracked_fn_on_tracked_specify.rs | ||
| tracked_fn_read_own_entity.rs | ||