mirror of
https://github.com/salsa-rs/salsa.git
synced 2025-01-23 13:10:19 +00:00
a2198f1f8a
If a query observes an untracked read, it gets changed_at equal to the current revision. When we re-validate the query later, if it doesn't do an untracked read this time, it gets changed_at equal to the maximum of the dependencies. Crucially, this new changed_at may be **older** then the previous value of changed_at. That is, we break the rule that `changed_at` monotonically increases. This can lead to missed re-executions down the line (see the added test). closes #66
115 lines
3.6 KiB
Rust
115 lines
3.6 KiB
Rust
use crate::setup::{Input, Knobs, ParDatabase, ParDatabaseImpl, WithValue};
|
|
use salsa::{Database, ParallelDatabase};
|
|
|
|
/// Add test where a call to `sum` is cancelled by a simultaneous
|
|
/// write. Check that we recompute the result in next revision, even
|
|
/// though none of the inputs have changed.
|
|
#[test]
|
|
fn in_par_get_set_cancellation_immediate() {
|
|
let mut db = ParDatabaseImpl::default();
|
|
|
|
db.query_mut(Input).set('a', 100);
|
|
db.query_mut(Input).set('b', 010);
|
|
db.query_mut(Input).set('c', 001);
|
|
db.query_mut(Input).set('d', 0);
|
|
|
|
let thread1 = std::thread::spawn({
|
|
let db = db.snapshot();
|
|
move || {
|
|
// This will not return until it sees cancellation is
|
|
// signaled.
|
|
db.knobs().sum_signal_on_entry.with_value(1, || {
|
|
db.knobs()
|
|
.sum_wait_for_cancellation
|
|
.with_value(true, || db.sum("abc"))
|
|
})
|
|
}
|
|
});
|
|
|
|
// Wait until we have entered `sum` in the other thread.
|
|
db.wait_for(1);
|
|
|
|
// Try to set the input. This will signal cancellation.
|
|
db.query_mut(Input).set('d', 1000);
|
|
|
|
// This should re-compute the value (even though no input has changed).
|
|
let thread2 = std::thread::spawn({
|
|
let db = db.snapshot();
|
|
move || db.sum("abc")
|
|
});
|
|
|
|
assert_eq!(db.sum("d"), 1000);
|
|
assert_eq!(thread1.join().unwrap(), std::usize::MAX);
|
|
assert_eq!(thread2.join().unwrap(), 111);
|
|
}
|
|
|
|
/// Here, we check that `sum`'s cancellation is propagated
|
|
/// to `sum2` properly.
|
|
#[test]
|
|
fn in_par_get_set_cancellation_transitive() {
|
|
let mut db = ParDatabaseImpl::default();
|
|
|
|
db.query_mut(Input).set('a', 100);
|
|
db.query_mut(Input).set('b', 010);
|
|
db.query_mut(Input).set('c', 001);
|
|
db.query_mut(Input).set('d', 0);
|
|
|
|
let thread1 = std::thread::spawn({
|
|
let db = db.snapshot();
|
|
move || {
|
|
// This will not return until it sees cancellation is
|
|
// signaled.
|
|
db.knobs().sum_signal_on_entry.with_value(1, || {
|
|
db.knobs()
|
|
.sum_wait_for_cancellation
|
|
.with_value(true, || db.sum2("abc"))
|
|
})
|
|
}
|
|
});
|
|
|
|
// Wait until we have entered `sum` in the other thread.
|
|
db.wait_for(1);
|
|
|
|
// Try to set the input. This will signal cancellation.
|
|
db.query_mut(Input).set('d', 1000);
|
|
|
|
// This should re-compute the value (even though no input has changed).
|
|
let thread2 = std::thread::spawn({
|
|
let db = db.snapshot();
|
|
move || db.sum2("abc")
|
|
});
|
|
|
|
assert_eq!(db.sum2("d"), 1000);
|
|
assert_eq!(thread1.join().unwrap(), std::usize::MAX);
|
|
assert_eq!(thread2.join().unwrap(), 111);
|
|
}
|
|
|
|
/// https://github.com/salsa-rs/salsa/issues/66
|
|
#[test]
|
|
fn no_back_dating_in_cancellation() {
|
|
let mut db = ParDatabaseImpl::default();
|
|
|
|
db.query_mut(Input).set('a', 1);
|
|
let thread1 = std::thread::spawn({
|
|
let db = db.snapshot();
|
|
move || {
|
|
// Here we compute a long-chain of queries,
|
|
// but the last one gets cancelled.
|
|
db.knobs().sum_signal_on_entry.with_value(1, || {
|
|
db.knobs()
|
|
.sum_wait_for_cancellation
|
|
.with_value(true, || db.sum3("a"))
|
|
})
|
|
}
|
|
});
|
|
|
|
db.wait_for(1);
|
|
// Set unrelated input to bumpision rev
|
|
db.query_mut(Input).set('b', 2);
|
|
|
|
// Here we should recompuet the whole chain again, clearing the cancellation
|
|
// state. If we get `usize::max()` here, it is a bug!
|
|
assert_eq!(db.sum3("a"), 1);
|
|
|
|
assert_eq!(thread1.join().unwrap(), std::usize::MAX);
|
|
}
|