From 2697112a8a5e429197287bcb999c53ddebe4c080 Mon Sep 17 00:00:00 2001 From: Antonio Scandurra Date: Fri, 9 Dec 2022 08:11:18 +0100 Subject: [PATCH] Don't drop `unregistered` column in reconnection support migration We don't use this column anymore because, when a project is unshared, we simply remove it from the `projects` table. However, this column is expected in the stable version of the server and the database is shared between stable and preview. If we dropped it, stable would start throwing errors. --- crates/collab/migrations.sqlite/20221109000000_test_schema.sql | 3 ++- .../collab/migrations/20221111092550_reconnection_support.sql | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/collab/migrations.sqlite/20221109000000_test_schema.sql b/crates/collab/migrations.sqlite/20221109000000_test_schema.sql index 90fd8ace12..68caf4fad7 100644 --- a/crates/collab/migrations.sqlite/20221109000000_test_schema.sql +++ b/crates/collab/migrations.sqlite/20221109000000_test_schema.sql @@ -44,7 +44,8 @@ CREATE TABLE "projects" ( "room_id" INTEGER REFERENCES rooms (id) NOT NULL, "host_user_id" INTEGER REFERENCES users (id) NOT NULL, "host_connection_id" INTEGER NOT NULL, - "host_connection_epoch" TEXT NOT NULL + "host_connection_epoch" TEXT NOT NULL, + "unregistered" BOOLEAN NOT NULL DEFAULT FALSE ); CREATE INDEX "index_projects_on_host_connection_epoch" ON "projects" ("host_connection_epoch"); diff --git a/crates/collab/migrations/20221111092550_reconnection_support.sql b/crates/collab/migrations/20221111092550_reconnection_support.sql index 5e8bada2f9..3289f6bbdd 100644 --- a/crates/collab/migrations/20221111092550_reconnection_support.sql +++ b/crates/collab/migrations/20221111092550_reconnection_support.sql @@ -6,8 +6,7 @@ CREATE TABLE IF NOT EXISTS "rooms" ( ALTER TABLE "projects" ADD "room_id" INTEGER REFERENCES rooms (id), ADD "host_connection_id" INTEGER, - ADD "host_connection_epoch" UUID, - DROP COLUMN "unregistered"; + ADD "host_connection_epoch" UUID; CREATE INDEX "index_projects_on_host_connection_epoch" ON "projects" ("host_connection_epoch"); CREATE TABLE "worktrees" (