From 457fbd742f8fdbeab89246868f1f722d329e8f0b Mon Sep 17 00:00:00 2001 From: Marshall Bowers Date: Wed, 22 May 2024 20:47:49 -0400 Subject: [PATCH] zig: Pin ZLS to v0.11.0 (#12173) This PR updates the Zig extension to pin ZLS to v0.11.0, as the more recent releases of ZLS don't have `.tar.gz` assets available. Note that this depends on the next version of the `zed_extension_api`, which has yet to be released. Release Notes: - N/A --- Cargo.lock | 2 +- extensions/zig/Cargo.toml | 2 +- extensions/zig/src/zig.rs | 12 +++++------- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 092876b393..a03d080b70 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -13338,7 +13338,7 @@ dependencies = [ name = "zed_zig" version = "0.1.2" dependencies = [ - "zed_extension_api 0.0.6", + "zed_extension_api 0.0.7", ] [[package]] diff --git a/extensions/zig/Cargo.toml b/extensions/zig/Cargo.toml index 89714bf450..5ddd06f106 100644 --- a/extensions/zig/Cargo.toml +++ b/extensions/zig/Cargo.toml @@ -13,4 +13,4 @@ path = "src/zig.rs" crate-type = ["cdylib"] [dependencies] -zed_extension_api = "0.0.6" +zed_extension_api = { path = "../../crates/extension_api" } diff --git a/extensions/zig/src/zig.rs b/extensions/zig/src/zig.rs index ccf243050d..a42d62be29 100644 --- a/extensions/zig/src/zig.rs +++ b/extensions/zig/src/zig.rs @@ -39,13 +39,11 @@ impl ZigExtension { &language_server_id, &zed::LanguageServerInstallationStatus::CheckingForUpdate, ); - let release = zed::latest_github_release( - "zigtools/zls", - zed::GithubReleaseOptions { - require_assets: true, - pre_release: false, - }, - )?; + // We're pinning ZLS to a release that has `.tar.gz` assets, since the latest release does not have + // them, at time of writing. + // + // ZLS tracking issue: https://github.com/zigtools/zls/issues/1879 + let release = zed::github_release_by_tag_name("zigtools/zls", "0.11.0")?; let (platform, arch) = zed::current_platform(); let asset_name = format!(