mirrors/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2025-02-05 10:20:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

Allow terminal to be docked left, bottom, or right

Browse source 
Co-Authored-By: Joseph Lyons <joseph@zed.dev>
This commit is contained in:
Nathan Sobo 2023-05-09 17:36:49 -06:00
parent 6a7feb4c4c
commit ba248244ec
2 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/project_panel/src/project_panel.rs
View file

@ -144,10 +144,8 @@ impl ProjectPanel {
let project_panel = cx.add_view(|cx: &mut ViewContext<Self>| {
// Update the dock position when the setting changes.
let mut old_dock_position = cx.global::<Settings>().project_panel_overrides.dock;
dbg!(old_dock_position);
cx.observe_global::<Settings, _>(move |_, cx| {
let new_dock_position = cx.global::<Settings>().project_panel_overrides.dock;
dbg!(new_dock_position);
if new_dock_position != old_dock_position {
old_dock_position = new_dock_position;
cx.emit(Event::DockPositionChanged);

16
crates/terminal_view/src/terminal_panel.rs
View file

@ -14,6 +14,7 @@ pub fn init(cx: &mut AppContext) {
pub enum Event {
Close,
DockPositionChanged,
}
pub struct TerminalPanel {
@ -25,6 +26,15 @@ pub struct TerminalPanel {
impl TerminalPanel {
pub fn new(workspace: &Workspace, cx: &mut ViewContext<Self>) -> Self {
let mut old_dock_position = cx.global::<Settings>().terminal_overrides.dock;
cx.observe_global::<Settings, _>(move |_, cx| {
let new_dock_position = cx.global::<Settings>().terminal_overrides.dock;
if new_dock_position != old_dock_position {
old_dock_position = new_dock_position;
cx.emit(Event::DockPositionChanged);
}
}).detach();
let this = cx.weak_handle();
let pane = cx.add_view(|cx| {
let window_id = cx.window_id();
@ -160,12 +170,12 @@ impl Panel for TerminalPanel {
}
}
fn should_change_position_on_event(_: &Self::Event) -> bool {
todo!()
fn should_change_position_on_event(event: &Self::Event) -> bool {
matches!(event, Event::DockPositionChanged)
}
fn should_activate_on_event(&self, _: &Self::Event, _: &AppContext) -> bool {
todo!()
false
}
fn should_close_on_event(&self, event: &Event, _: &AppContext) -> bool {