ok/jj
1
0
Fork 0
forked from mirrors/jj
Code Pull requests Activity

git_backend: forcibly invalidate in-memory packed-refs cache on gc()

Browse source 
gix 0.63 is now available.

#3537
This commit is contained in:
Yuya Nishihara 2024-05-23 21:49:38 +09:00
parent 02eb164dae
commit 68160a4e77
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/src/git_backend.rs
View file

@ -1222,13 +1222,11 @@ impl Backend for GitBackend {
// preserved by the keep_newer timestamp though)
// TODO: remove unreachable extras table segments
// TODO: pass in keep_newer to "git gc" command
run_git_gc(self.git_repo_path()).map_err(|err| BackendError::Other(err.into()))
// TODO: Since "git gc" will move loose refs into packed refs, in-memory
// packed-refs cache should be invalidated here. If mtime accuracy is
// high or "git gc" is slow enough, gix::RefStore can notice the change,
// but it's not always the case. Upgrade gix to 0.63.0 and call
// force_refresh_packed_buffer().
// https://github.com/Byron/gitoxide/issues/1348
run_git_gc(self.git_repo_path()).map_err(|err| BackendError::Other(err.into()))?;
// Since "git gc" will move loose refs into packed refs, in-memory
// packed-refs cache should be invalidated without relying on mtime.
git_repo.refs.force_refresh_packed_buffer().ok();
Ok(())
}
}