mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2024-11-28 17:44:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove error message for not implementing set_backend_req_connection

Browse source 
This error message is displayed on using the vhost-user block
implementation.
```
ERROR devices::virtio::vhost::user::device::handler] set_backend_req_connection is not implemented
```

fmayle@ and dverkamp@ pointed out in code review that this doesn't
signify an actual error, as crosvm also handles this message at a
different layer.

Bug: b:347308400
Test: Run with cuttlefish
Change-Id: I59f5fcefbc60aab4b2b1d7c188740eb6289bee41
Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5634186
Commit-Queue: Cody Schuffelen <schuffelen@google.com>
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Reviewed-by: Frederick Mayle <fmayle@google.com>
This commit is contained in:
A. Cody Schuffelen 2024-06-14 12:38:26 -07:00 committed by crosvm LUCI
parent ba06509a5c
commit 9227b78c4f
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
devices/src/virtio/vhost/user/device/handler.rs
View file

@ -185,9 +185,7 @@ pub trait VhostUserDevice {
///
/// This method will be called when `VhostUserProtocolFeatures::BACKEND_REQ` is
/// negotiated.
fn set_backend_req_connection(&mut self, _conn: Arc<VhostBackendReqConnection>) {
error!("set_backend_req_connection is not implemented");
}
fn set_backend_req_connection(&mut self, _conn: Arc<VhostBackendReqConnection>) {}
/// Used to stop non queue workers that `VhostUserDevice::stop_queue` can't stop. May or may
/// not also stop all queue workers.