mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2024-11-24 20:48:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

hypervisor: disable getsec and invvpid tests on Linux

Browse source 
These tests currently don't pass on KVM (at least on AMD), and I don't
think the tests are actually testing for the expected result (there is
no configured IDT, so the system triple faults and ends up at the reset
vector), which seems nontrivial to fix, so skip them on Linux for now.

This makes `tools/dev_container tools/presubmit` pass for me again.

Change-Id: Ifc31fdd88b270c1c37f0f105dc655be4048ed279
Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5888352
Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
Commit-Queue: Daniel Verkamp <dverkamp@chromium.org>
Reviewed-by: Frederick Mayle <fmayle@google.com>
This commit is contained in:
Daniel Verkamp 2024-09-24 14:17:19 -07:00 committed by crosvm LUCI
parent 09e715bf61
commit f2d11d94d7
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
hypervisor/tests/hypervisor_virtualization.rs
View file

@ -1381,6 +1381,7 @@ global_asm_data!(
"hlt",
);
#[cfg(not(unix))]
#[test]
fn test_getsec_instruction() {
let setup = TestSetup {
@ -1605,6 +1606,7 @@ global_asm_data!(
// TODO(b/342183625): invvpid instruction is not valid in real mode. Reconsider how we should write
// this test.
#[cfg(not(unix))]
#[test]
fn test_invvpid_instruction() {
let setup = TestSetup {