mirrors/jj
1
0
Fork 1
mirror of https://github.com/martinvonz/jj.git synced 2024-11-24 15:18:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

docs: try to clarify that we want contributors to squash fixup commits

Browse source 
It's happened a few times that contributors misunderstood the
guidelines, so they're clearly not clear enough. Hopefully this
clarifies.
This commit is contained in:
Martin von Zweigbergk 2023-09-07 08:14:00 -07:00 committed by Martin von Zweigbergk
parent 8660b39b4c
commit 233b31fdf2
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
docs/contributing.md
View file

@ -27,7 +27,8 @@ information on using pull requests.
Unlike many GitHub projects (but like many VCS projects), we care more about the
contents of commits than about the contents of PRs. We review each commit
separately, and we don't squash them when the PR is ready.
separately, and we don't squash-merge the PR (so please manually squash any
fixup commits before sending for review).
Each commit should ideally do one thing. For example, if you need to refactor a
function in order to add a new feature cleanly, put the refactoring in one