Marshall Bowers
90f4c70a82
Rename h_stack
and v_stack
to h_flex
and v_flex
, respectively ( #4053 )
...
This PR renames the `h_stack` and `v_stack` to `h_flex` and `v_flex`,
respectively.
We were previously using `h_stack` and `v_stack` to match SwiftUI, but
`h_flex` and `v_flex` fit better with the web/flexbox terminology that
the rest of GPUI uses.
Additionally, we were already calling the utility functions used to
implement `h_stack` and `v_stack` by the new names.
Release Notes:
- N/A
2024-01-15 11:34:06 -05:00
Marshall Bowers
b136d21ebf
Make tab close button square ( #4052 )
...
This PR makes the close button for tabs square.
`IconButton` now accepts a `shape`, and using `IconButtonShape::Square`
will ensure the `IconButton` is square with respect to its contained
icon.
#### Before
<img width="119" alt="Screenshot 2024-01-15 at 10 32 40 AM"
src="https://github.com/zed-industries/zed/assets/1486634/dc806b9b-411f-4cd9-8c10-676d2cbd298b ">
#### After
<img width="116" alt="Screenshot 2024-01-15 at 10 32 24 AM"
src="https://github.com/zed-industries/zed/assets/1486634/8b4ef43c-14b6-449f-a235-5d7affd82c4e ">
Release Notes:
- Changed the tab close button to be square.
2024-01-15 10:43:03 -05:00
Antonio Scandurra
1da9c8b1e9
Rebuild shader header when cbindgen sources have changed ( #4051 )
...
This was causing the Metal shaders to incorrectly interpret the
primitives submitted by GPUI, which in turn caused rendering to be
completely borked.
Release Notes:
- N/A
2024-01-15 16:32:09 +01:00
Julia
ef4831b868
Prevent storybook dialog from swallowing terminal cursor when ctrl-c-ed ( #4050 )
...
Honestly thought this was a bug with our terminal port lol. Turns out
its an oversight in the `dialoguer` crate but its seems pretty easy to
work around so might as well
Release Notes:
- N/A
2024-01-15 10:25:11 -05:00
Antonio Scandurra
0ff5603dc9
Rebuild shader header when cbindgen sources have changed
...
Co-Authored-By: Thorsten <thorsten@zed.dev>
2024-01-15 16:23:22 +01:00
Julia
5000a53a61
Prevent storybook dialog from swallowing terminal cursor when ctrl-c-ed
2024-01-15 10:19:08 -05:00
Piotr Osiewicz
e52a2298cc
gpui: Pin to font-kit with improved OTC parsing performance. ( #4047 )
...
Details are in https://github.com/zed-industries/font-kit/pull/1 ; We're
not doing anything too fancy, really. Still, you should mostly see font
loading times drop significantly for font collections
Release Notes:
- Improved loading performance of large font collections (e.g. Iosevka).
Fixes https://github.com/zed-industries/community/issues/1745 ,
https://github.com/zed-industries/community/issues/246
https://github.com/zed-industries/zed/assets/24362066/f70edbad-ded6-4c12-9c6d-7a487f330a1b
2024-01-15 15:46:18 +01:00
Kirill Bulatov
f061015609
Do not run squawk tests outside of PR builds ( #4049 )
...
Release Notes:
- N/A
2024-01-15 16:24:15 +02:00
Kirill Bulatov
346103dfb4
Do not run squawk tests outside of PR builds
2024-01-15 16:20:53 +02:00
Kirill Bulatov
fc294ce0b1
Disable copilot for feedback and lsp log editors ( #4048 )
...
LSP log editor caused recursive flood of messages, and feedback editor
is better with people writing their own feedback.
Release Notes:
- Fixed hanging due to excessive logs when browsing Copilot LSP logs
2024-01-15 15:59:27 +02:00
Kirill Bulatov
253c8dbe8e
Disable copilot for feedback and lsp log editors
...
LSP log editor caused recursive flood of messages, and feedback editor is better with people writing their own feedback.
2024-01-15 15:49:23 +02:00
Thorsten Ball
80c0d09b15
Fix editor stealing click events from copy-error button ( #4046 )
...
This fixes the click event on the "copy error message" button by
changing the `editor` element to ignore mouse-down events when the
default was prevented. That's similar to how `div` does it.
Release Notes:
- Fixed a bug that prevented "copy error message" button from being
clicked.
2024-01-15 14:03:15 +01:00
Thorsten Ball
74f3366f42
Fix editor stealing click events from copy-error button
...
Co-authored-by: Antonio <antonio@zed.dev>
2024-01-15 13:47:09 +01:00
Antonio Scandurra
9c672f7820
Introduce view caching ( #4019 )
...
<img width="996" alt="image"
src="https://github.com/zed-industries/zed/assets/482957/a5683382-6ff1-4558-9e9b-ebc17bc00289 ">
TODO:
- [x] Fix rename editor not updating
Release Notes:
- Improved rendering performance when editing.
2024-01-15 13:26:08 +01:00
Antonio Scandurra
05d05b051b
Pop node from dispatch tree during cx.paint_view
...
Co-Authored-By: Thorsten <thorsten@zed.dev>
2024-01-15 11:46:46 +01:00
Antonio Scandurra
4ff514ca7e
Merge remote-tracking branch 'origin/main' into cache
...
# Conflicts:
# crates/gpui/src/elements/div.rs
2024-01-15 11:37:46 +01:00
Conrad Irwin
600b5c65e9
Try sqwauk ( #4032 )
...
It'd be nice to automatically get warned if you're about to do a
backward incompatible migration mistakenly, and sqauwk does exactly
that.
Release Notes:
- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/ <public_issue_number_if_exists>)).
2024-01-14 13:54:35 -07:00
Conrad Irwin
29ce109211
chat panel ++ ( #4044 )
...
- Update chat panel with current channel
- Open chat panel for guests
- Open chat when joining a channel with guests
- Some tweaks for chat panels
- Don't lose focus on default panel state
- Make chat prettier (to my eyes at least)
- Fix multiple mentions in one message
- Show a border when scrolled in chat
- Fix re-docking chat panel
- Move settings subscription to dock
[[PR Description]]
Release Notes:
- Opens chat by default when joining a public channel
- Improves chat panel UI
2024-01-14 13:54:10 -07:00
Conrad Irwin
b34c78016f
Fix tests for TestPanel
2024-01-14 12:26:54 -07:00
Conrad Irwin
27c48d9fd3
Default to Zed Sans for UI ( #4045 )
...
Release Notes:
- Improve legibility of default UI font
2024-01-14 12:22:32 -07:00
Conrad Irwin
4d87a67af8
Remove unused imports
2024-01-13 22:44:47 -07:00
Conrad Irwin
898645681f
Move settings subscription to dock
...
Reduces likelihood of panels being unable to move themselves
2024-01-13 22:41:26 -07:00
Conrad Irwin
e90ddba2c3
Default to Zed Sans for UI
2024-01-13 22:38:22 -07:00
Conrad Irwin
fee369bca1
Fix re-docking chat panel
2024-01-13 22:26:25 -07:00
Conrad Irwin
818cbb2415
Show a border when scrolled in chat
2024-01-13 22:19:21 -07:00
Conrad Irwin
c810af40d3
Fix multiple mentions in one message
2024-01-13 21:53:22 -07:00
Conrad Irwin
f6ef07e716
Make chat prettier (to my eyes at least)
2024-01-13 21:37:13 -07:00
Conrad Irwin
c2ff9fe2da
Don't lose focus on default panel state
2024-01-13 14:32:24 -07:00
Mikayla Maki
89f0d1643e
Restore temp file initialization in telemetry code ( #4043 )
...
Release Notes:
- Fix 'open telemetry log' command to actually show the telemetry log.
2024-01-13 09:04:08 -08:00
Mikayla
4d6dfa319d
Don't open files unescessary in dev builds
2024-01-12 22:47:07 -08:00
Mikayla
1d7dc96135
Restore temp file initialization in telemetry code
2024-01-12 21:37:09 -08:00
Mikayla Maki
acb13738b8
Disable searches for '.' in the terminal. ( #4042 )
...
Release Notes:
- N/A A crash that could occur when searching for '.' in the terminal
with a large monitor.
2024-01-12 21:17:10 -08:00
Mikayla
78858d4d11
Disable searches for '.', so that users with large monitors don't accidentally crash the terminal when searching for dot files.
2024-01-12 21:12:02 -08:00
Mikayla Maki
adab1ccb5d
Remove last commented code ( #4041 )
...
Release Notes:
- N/A
2024-01-12 21:08:39 -08:00
Mikayla
bb35805f9b
fmt
2024-01-12 21:02:01 -08:00
Mikayla
bfb59f1598
Remove last stale code
2024-01-12 20:59:19 -08:00
Mikayla
5897b18cfd
remove more commented code
2024-01-12 20:10:40 -08:00
Mikayla
3a836b8026
Remove some comments
2024-01-12 20:10:40 -08:00
Nathan Sobo
d2c436dcdc
fix bounds checks ( #4038 )
...
Ensure we `panic()` instead of crash on graphics memory buffer overflow
Also bump the buffer size to 32Mb from 8Mb to make this rarer (but still
possible)
Release Notes: Fixes some crahes due to lack of graphics buffer spacae
2024-01-12 15:28:19 -08:00
Conrad Irwin
eafe0944e0
Some tweaks for chat panels
2024-01-12 16:01:51 -07:00
Julia
8014d9a643
Still paint group hover handler for invisible divs ( #4039 )
...
Fixes bug where tab close icon show on hover is inconsistent
Release Notes:
- Fixed a bug where a tab's close icon would not always appear on hover.
2024-01-12 17:52:24 -05:00
Julia
cdc227b32f
Still paint group hover handler for invisible divs
...
Fixes bug where tab close icon show on hover is inconsistent
2024-01-12 17:44:15 -05:00
Conrad Irwin
50f3bbbc8b
Open chat when joining a channel with guests
...
(and close it when leaving a channel again)
2024-01-12 15:08:14 -07:00
Conrad Irwin
aa5c6a8aa3
Update graphics memory assert to be more helpful
2024-01-12 14:35:50 -07:00
Mikayla
324d1d119b
Add some context to assert
2024-01-12 12:40:37 -08:00
Conrad Irwin
551fd9ba7e
Boop
2024-01-12 12:40:09 -07:00
Max Brunsfeld
c2d56cd5f8
Forbid paste, undo, redo on read-only editors ( #4037 )
...
Release Notes:
- Fixed a bug where guests could paste into buffers that were intended
to be read-only.
2024-01-12 11:26:44 -08:00
Max Brunsfeld
7dc28aad78
Forbid paste, undo, redo on read-only editors
2024-01-12 10:38:05 -08:00
Conrad Irwin
f0d490c671
Open chat panel for guests
2024-01-12 10:34:24 -07:00
Conrad Irwin
dc158f708f
Update chat panel with current channel
2024-01-12 10:23:30 -07:00