Summary: This adds VDSO stubs for aarch64 so that we can intercept VDSO calls. See the comments in the code for more details.
Reviewed By: VladimirMakaev
Differential Revision: D40867428
fbshipit-source-id: 136818d9dbf52f4297dd4dae041e3e6dfe0764ae
Summary: Update from 0.2.135 to 0.2.137, the latest version on crates.io, in preparation for backporting a PR in the diff after this one.
Reviewed By: zertosh
Differential Revision: D40874274
fbshipit-source-id: debf9dae82ecc20201470e634f10904a2b308e51
Summary: To do proper feature detection on the CPU to know if we can get perf events, there is more work to do here. See the comment on `get_rcb_perf_config` for more info.
Reviewed By: VladimirMakaev
Differential Revision: D40701837
fbshipit-source-id: 4c7a7c00be0ab14e4fe9f4be09c8094567d5d031
Summary: This is a more architecture-independent name.
Reviewed By: VladimirMakaev
Differential Revision: D40701833
fbshipit-source-id: 66b77c6f62886ecd776a3efbc0b71248f875914e
Summary: These definitions are x86_64-specific, so they should be defined in their own file. Later, we'll add definitions for aarch64.
Reviewed By: VladimirMakaev
Differential Revision: D40701840
fbshipit-source-id: 0c52334dc7eb9bb60020c45c3f2ef58077c20322
Summary:
Followed guide here https://www.internalfb.com/intern/wiki/Linting/License_Lint/ to add fbcode/hermetic_infra/** code to license linter. As we have parts of our code shipped as Open Source it's important to get this automated
This diff is updating existing file's licenses to not get conflict after lint rule enablement
Reviewed By: jasonwhite
Differential Revision: D40674080
fbshipit-source-id: da6ecac036f8964619cf7912058f3a911558e7b1
Summary:
This abstracts the set of general purpose registers so that we can more easily access special registers in an architecture-independent way.
The rest of the code will be refactored to use this new interface in a later change.
Reviewed By: wangbj
Differential Revision: D40577289
fbshipit-source-id: 313a3ab3863f09a506b6e61fb67093fc49eeae3e
Summary: This release makes async trait methods work better with rust-analyzer's "go to definition" and other IDE functionality.
Reviewed By: zertosh
Differential Revision: D40532047
fbshipit-source-id: 1871d1819ebe1aab0846b0135f051c45e6e8821b
Summary:
On devvm5443.atn0.facebook.com (Intel Xeon Processor (Skylake)), I observed a slippage a bit past the skid of 50:
✉ Timeout: hermetic_infra/hermit/tests:hermit_run_strict__sh_par_work - main (300.011)
Test output:
> from_execution_error::timeout::LocalExecutor::Timeout
:: Run1...
thread 'main' panicked at 'Clock perf counter exceeds target value at start of attempted single-step: 23417931 > 23417927. Consider increasing SKID_MARGIN_RCBS.', hermetic_infra/reverie/reverie-ptrace/src/timer.rs:562:9
Therefore I'm bumping it to 60.
This is unfortunate, because it directly slows down our chaos mode preemptions (until we eventually get an emulator), but I'm therefore bumping the skid margin.
We could also potentially set it differently for devvm and for bare metal.
Reviewed By: jasonwhite
Differential Revision: D40383171
fbshipit-source-id: 34bb8217a61fc2c77f1d45d23b8c28f91cae5efc
Summary: Get reverie-syscalls building on aarch64
Reviewed By: jasonwhite
Differential Revision: D40323777
fbshipit-source-id: bc7a326dc06deb2247a4b2a8f784b05745e961b7
Summary: This updates the libc crate to 0.2.135, which includes the FICLONE constant needed to the given ioctl.
Reviewed By: justintrudell
Differential Revision: D40286796
fbshipit-source-id: acfa115479cd289f478d8d73937be34ced5c4bbb
Summary: Ran regex `#\[clap.*?help` to locate single line clap options with help messages and manually went through several multiline ones.
Reviewed By: jasonwhite
Differential Revision: D40297841
fbshipit-source-id: 108d9da70f9a3bd096167e41c287a4a959b10c17
Summary:
When I was trying to use `nix::unistd::gethostname` in D39783468, the version `0.23.0` will require users to pass in a `buf` as a parameter, however, in `0.25.0`, there is no need to pass in a `buf` as a parameter. Hence, I would love to update `nix` crate from `0.23` to `0.25` in order to not pass a redundant `buf` while calling `nix::unistd::gethostname`.
I fixed conflicts reflected from the signals manually so this diff is more than a few lines of code in `Cargo.toml`.
Here are the [changes](https://github.com/nix-rust/nix/compare/v0.23.0..v0.25.0) between `0.23` and `0.25`. See `CHANGELOG.md` for the most significant changes in this version.
Reviewed By: bgw
Differential Revision: D39919100
fbshipit-source-id: 7f62585ff72230bd2608aeb5a4780dc0128795f7
Summary:
See rationale in the linked task
I was planning to build a new CLI and decided to follow CLI Foundation recommentation. Since hermit is effectively not released it's a good time to migrate now which hasn't been hard mostly followed the fastmods on the task and and some manual fixes of the remaining code
Reviewed By: jasonwhite
Differential Revision: D39953166
fbshipit-source-id: 6e917c6a8ea2ee8258e7e6068e9c9e787ebf0989
Summary: Currently 'sysinfo' isn't being captured and determinized this might be a source of some divergencies in heap & stack. This diff with handle 'sysinfo' with hardcoded reasonable values. Follow up diffs with further enhance this
Reviewed By: rrnewton
Differential Revision: D39546772
fbshipit-source-id: a5a49e882a0fea4512bf991d257b0f8072f7f792
Summary: D39418421 (8fef664fab) prematurely upgraded `thiserror`. Various projects in fbcode use nightly features including std::backtrace but the current fbcode Rust toolchain is 1.63.0, in which the backtrace API is different from the API of the latest nightlies.
Reviewed By: quark-zju
Differential Revision: D39562441
fbshipit-source-id: d1f8a993ec776cf82b1736b242bd4466def21230
Summary: This will help reverie-ptrace slowly migrate towards supporting `aarch64` as well as `x86_64`.
Reviewed By: jasonwhite
Differential Revision: D38787872
fbshipit-source-id: e747c59da8f0c59f0b85a50888c884dbbed65824
Summary:
X-link: https://github.com/facebookresearch/Private-ID/pull/71
Previous codemod left some crust. This commit cleans up useless uses to use less uses.
Reviewed By: stepancheg
Differential Revision: D38211793
fbshipit-source-id: c852dd1ec617fe81a1d9bd0d8a9e5d2357b9b502
